From 1d2043e806cb70905619e0b11e5d4a5d73388000 Mon Sep 17 00:00:00 2001 From: lightclient <14004106+lightclient@users.noreply.github.com> Date: Thu, 27 Feb 2025 00:40:35 -0700 Subject: [PATCH] eth/gasprice: sanity check ratio values (#31270) Follow on to #31246. Adds a sanity check in the test to make sure the ratio value never goes over 1. Would have avoided the issue in #31245. --- eth/gasprice/feehistory_test.go | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/eth/gasprice/feehistory_test.go b/eth/gasprice/feehistory_test.go index 241b91b810..d220027e69 100644 --- a/eth/gasprice/feehistory_test.go +++ b/eth/gasprice/feehistory_test.go @@ -84,9 +84,19 @@ func TestFeeHistory(t *testing.T) { if len(ratio) != c.expCount { t.Fatalf("Test case %d: gasUsedRatio array length mismatch, want %d, got %d", i, c.expCount, len(ratio)) } + for _, ratio := range ratio { + if ratio > 1 { + t.Fatalf("Test case %d: gasUsedRatio greater than 1, got %f", i, ratio) + } + } if len(blobRatio) != c.expCount { t.Fatalf("Test case %d: blobGasUsedRatio array length mismatch, want %d, got %d", i, c.expCount, len(blobRatio)) } + for _, ratio := range blobRatio { + if ratio > 1 { + t.Fatalf("Test case %d: blobGasUsedRatio greater than 1, got %f", i, ratio) + } + } if len(blobBaseFee) != len(baseFee) { t.Fatalf("Test case %d: blobBaseFee array length mismatch, want %d, got %d", i, len(baseFee), len(blobBaseFee)) }