forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-19 02:12:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

core/state: address comments

Browse source
This commit is contained in:
Gary Rong 2024-08-27 13:54:26 +08:00
parent 542b83ce19
commit 01f050b96e
3 changed files with 5 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
core/state/journal.go
View file

@ -63,9 +63,9 @@ func newJournal() *journal {
} }
} }
// reset clears the journal, after this operation the journal can be used // reset clears the journal, after this operation the journal can be used anew.
// as new. It is semantically similar to calling 'newJournal', but the underlying // It is semantically similar to calling 'newJournal', but the underlying slices
// slices can be reused. // can be reused.
func (j *journal) reset() { func (j *journal) reset() {
j.entries = j.entries[:0] j.entries = j.entries[:0]
j.validRevisions = j.validRevisions[:0] j.validRevisions = j.validRevisions[:0]
@ -192,7 +192,7 @@ func (j *journal) balanceChange(addr common.Address, previous *uint256.Int) {
}) })
} }
func (j *journal) codeChange(address common.Address) { func (j *journal) setCode(address common.Address) {
j.append(codeChange{account: &address}) j.append(codeChange{account: &address})
} }

2
core/state/state_object.go
View file

@ -574,7 +574,7 @@ func (s *stateObject) CodeSize() int {
} }
func (s *stateObject) SetCode(codeHash common.Hash, code []byte) { func (s *stateObject) SetCode(codeHash common.Hash, code []byte) {
s.db.journal.codeChange(s.address) s.db.journal.setCode(s.address)
if s.db.logger != nil && s.db.logger.OnCodeChange != nil { if s.db.logger != nil && s.db.logger.OnCodeChange != nil {
// TODO remove prevcode from this callback // TODO remove prevcode from this callback
s.db.logger.OnCodeChange(s.address, common.BytesToHash(s.CodeHash()), nil, codeHash, code) s.db.logger.OnCodeChange(s.address, common.BytesToHash(s.CodeHash()), nil, codeHash, code)

3
core/state/statedb.go
View file

@ -500,9 +500,6 @@ func (s *StateDB) SelfDestruct(addr common.Address) {
// Regardless of whether it is already destructed or not, we do have to // Regardless of whether it is already destructed or not, we do have to
// journal the balance-change, if we set it to zero here. // journal the balance-change, if we set it to zero here.
if !stateObject.Balance().IsZero() { if !stateObject.Balance().IsZero() {
if s.logger != nil && s.logger.OnBalanceChange != nil {
s.logger.OnBalanceChange(addr, stateObject.Balance().ToBig(), new(big.Int), tracing.BalanceDecreaseSelfdestruct)
}
stateObject.SetBalance(new(uint256.Int), tracing.BalanceDecreaseSelfdestruct) stateObject.SetBalance(new(uint256.Int), tracing.BalanceDecreaseSelfdestruct)
} }
// If it is already marked as self-destructed, we do not need to add it // If it is already marked as self-destructed, we do not need to add it