forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-20 10:52:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

p2p/discover: try to fix TestUDPv5_lookupE2E by using SetFallbackUDP (#35542)
Some checks are pending
/ Linux Build (push) Waiting to run
Details
/ Linux Build (arm) (push) Waiting to run
Details
/ Keeper Build (push) Waiting to run
Details
/ Windows Build (push) Waiting to run
Details
/ Docker Image (push) Waiting to run
Details

Browse source 
The test set the local UDP port via ln.Set(enr.UDP(...)), but the "udp"
ENR entry is owned by the endpoint predictor: as soon as the first node
received a PONG, updateEndpoints recomputed the endpoint with no
fallback port set and deleted the entry. Later nodes bootstrapping from
that node's record then failed with "bad bootstrap node: missing UDP
port".

Use SetFallbackUDP like startLocalhostV4 already does, so the port
survives endpoint statements.

fixes CI errors like in
https://github.com/ethereum/go-ethereum/actions/runs/31859911877/job/94953524792?pr=35529
This commit is contained in:
Csaba Kiraly 2026-08-20 10:58:14 +02:00 committed by GitHub
parent 35a016346f
commit 02b73d4ea7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
p2p/discover/v5_udp_test.go
View file

@ -90,7 +90,7 @@ func startLocalhostV5(t *testing.T, cfg Config) *UDPv5 {
} }
realaddr := socket.LocalAddr().(*net.UDPAddr) realaddr := socket.LocalAddr().(*net.UDPAddr)
ln.SetStaticIP(realaddr.IP) ln.SetStaticIP(realaddr.IP)
ln.Set(enr.UDP(realaddr.Port)) ln.SetFallbackUDP(realaddr.Port)
udp, err := ListenV5(socket, ln, cfg) udp, err := ListenV5(socket, ln, cfg)
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)