forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-21 20:26:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Handle endianness for CALLDATALOAD correctly [#79877740]

Browse source
This commit is contained in:
Paweł Bylica 2014-10-21 17:35:18 +02:00
parent 8909c150a1
commit 05741c2d4e
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
libevmjit/Ext.cpp
View file

@ -8,6 +8,7 @@
#include <libdevcrypto/SHA3.h> #include <libdevcrypto/SHA3.h>
#include "Runtime.h" #include "Runtime.h"
#include "Endianness.h"
using namespace llvm; using namespace llvm;
@ -145,7 +146,8 @@ Value* Ext::calldataload(Value* _index)
{ {
m_builder.CreateStore(_index, m_args[0]); m_builder.CreateStore(_index, m_args[0]);
m_builder.CreateCall(m_calldataload, m_args); m_builder.CreateCall(m_calldataload, m_args);
return m_builder.CreateLoad(m_args[1]); auto ret = m_builder.CreateLoad(m_args[1]);
return Endianness::toNative(m_builder, ret);
} }
Value* Ext::bswap(Value* _value) Value* Ext::bswap(Value* _value)
@ -282,8 +284,8 @@ EXPORT void ext_calldataload(i256* _index, i256* _value)
auto index = static_cast<size_t>(llvm2eth(*_index)); auto index = static_cast<size_t>(llvm2eth(*_index));
assert(index + 31 > index); // TODO: Handle large index assert(index + 31 > index); // TODO: Handle large index
auto b = reinterpret_cast<byte*>(_value); auto b = reinterpret_cast<byte*>(_value);
for (size_t i = index, j = 31; i <= index + 31; ++i, --j) for (size_t i = index, j = 0; i <= index + 31; ++i, ++j)
b[j] = i < Runtime::getExt().data.size() ? Runtime::getExt().data[i] : 0; b[j] = i < Runtime::getExt().data.size() ? Runtime::getExt().data[i] : 0; // Keep Big Endian
// TODO: It all can be done by adding padding to data or by using min() algorithm without branch // TODO: It all can be done by adding padding to data or by using min() algorithm without branch
} }