forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-20 10:52:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

log: lint nits

Browse source
This commit is contained in:
Martin Holst Swende 2023-11-29 20:07:41 +01:00
parent b7933d28e7
commit 05d7169c8b
No known key found for this signature in database
GPG key ID: 683B438C05A5DDF0
1 changed files with 1 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
log/logger_test.go
View file

@ -72,10 +72,6 @@ func BenchmarkJSONHandler(b *testing.B) {
} }
func benchmarkLogger(b *testing.B, l Logger) { func benchmarkLogger(b *testing.B, l Logger) {
type custom struct {
A string
B int8
}
var ( var (
bb = make([]byte, 10) bb = make([]byte, 10)
tt = time.Now() tt = time.Now()
@ -136,12 +132,11 @@ func TestLoggerOutput(t *testing.T) {
have := out.String() have := out.String()
t.Logf("output %v", out.String()) t.Logf("output %v", out.String())
want := `INFO [11-07|19:14:33.821] This is a message foo=123 bytes="[0 0 0 0 0 0 0 0 0 0]" bonk="a string with text" time=0001-01-01T00:00:00+0000 bigint=100 nilbig=<nil> err="Oh nooes it's crap" struct="{A:Foo B:12}" struct="{A:Foo\nLinebreak B:122}" ptrstruct="&{A:Foo B:12}" lazy="lazy value" smalluint=500,000 bigUint=1,600,660,942,523,603,594,864,898,306,482,794,244,293,965,082,972,225,630,372,095 want := `INFO [11-07|19:14:33.821] This is a message foo=123 bytes="[0 0 0 0 0 0 0 0 0 0]" bonk="a string with text" time=0001-01-01T00:00:00+0000 bigint=100 nilbig=<nil> err="Oh nooes it's crap" struct="{A:Foo B:12}" struct="{A:Foo\nLinebreak B:122}" ptrstruct="&{A:Foo B:12}" lazy="lazy value" smalluint=500,000 bigUint=1,600,660,942,523,603,594,864,898,306,482,794,244,293,965,082,972,225,630,372,095
` `
if !bytes.Equal([]byte(have)[25:], []byte(want)[25:]) { if !bytes.Equal([]byte(have)[25:], []byte(want)[25:]) {
t.Errorf("Error\nhave: %q\nwant: %q", have, want) t.Errorf("Error\nhave: %q\nwant: %q", have, want)
} }
} }
const termTimeFormat = "01-02|15:04:05.000" const termTimeFormat = "01-02|15:04:05.000"
@ -151,7 +146,6 @@ func BenchmarkAppendFormat(b *testing.B) {
b.Run("fmt time.Format", func(b *testing.B) { b.Run("fmt time.Format", func(b *testing.B) {
for i := 0; i < b.N; i++ { for i := 0; i < b.N; i++ {
fmt.Fprintf(io.Discard, "%s", now.Format(termTimeFormat)) fmt.Fprintf(io.Discard, "%s", now.Format(termTimeFormat))
} }
}) })
b.Run("time.AppendFormat", func(b *testing.B) { b.Run("time.AppendFormat", func(b *testing.B) {