forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-21 20:26:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

removed fast path in startSpan

Browse source
This commit is contained in:
jonny rhea 2026-01-07 18:36:53 -06:00
parent f6289f1a46
commit 0897f08389
1 changed files with 1 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
internal/telemetry/telemetry.go
View file

@ -59,11 +59,6 @@ func StartServerSpan(ctx context.Context, tracer trace.Tracer, rpc RPCInfo, othe
trace.WithSpanKind(trace.SpanKindServer), trace.WithSpanKind(trace.SpanKindServer),
) )
// Fast path: noop provider or span not sampled
if !span.IsRecording() {
return ctx, func(error) { span.End() }
}
// Define required attributes // Define required attributes
attrs := []Attribute{ attrs := []Attribute{
semconv.RPCSystemKey.String(rpc.System), semconv.RPCSystemKey.String(rpc.System),
@ -112,11 +107,7 @@ func startSpan(
trace.WithSpanKind(trace.SpanKindInternal), trace.WithSpanKind(trace.SpanKindInternal),
) )
// Fast path // Set attributes if any are provided
if !span.IsRecording() {
return ctx, span, func(error) { span.End() }
}
if len(attributes) > 0 { if len(attributes) > 0 {
span.SetAttributes(attributes...) span.SetAttributes(attributes...)
} }