common: simplify test a bit

common/types_test.go

@@ -598,70 +598,27 @@ func BenchmarkPrettyDuration(b *testing.B) {
 }
 
 func TestDecimalUnmarshalJSON(t *testing.T) {
-	type args struct {
+	// These should error
-		input []byte
+	for _, tc := range []string{``, `"`, `""`, `"-1"`} {
+		if err := new(Decimal).UnmarshalJSON([]byte(tc)); err == nil {
+			t.Errorf("input %s should cause error", tc)
+		}
 	}
-	d := Decimal(0)
+	// These should succeed
-	tests := []struct {
+	for _, tc := range []struct {
-		name        string
+		input string
-		d           *Decimal
+		want  uint64
-		args        args
-		wantErr     bool
-		expectedVal uint64
 	}{
-		{
+		{`"0"`, 0},
-			name:    "invalid number string",
+		{`"9223372036854775807"`, math.MaxInt64},
-			d:       &d,
+		{`"18446744073709551615"`, math.MaxUint64},
-			args:    args{[]byte(``)},
+	} {
-			wantErr: true,
+		have := new(Decimal)
-		}, {
+		if err := have.UnmarshalJSON([]byte(tc.input)); err != nil {
-			name:    "invalid number string",
+			t.Errorf("input %q triggered error: %v", tc.input, err)
-			d:       &d,
+		}
-			args:    args{[]byte(`"`)},
+		if uint64(*have) != tc.want {
-			wantErr: true,
+			t.Errorf("input %q, have %d want %d", tc.input, *have, tc.want)
-		},
+		}
-		{
-			name:    "invalid empty string",
-			d:       &d,
-			args:    args{[]byte(`""`)},
-			wantErr: true,
-		},
-		{
-			name:    "invalid negetive number string",
-			d:       &d,
-			args:    args{[]byte(`"-1"`)},
-			wantErr: true,
-		},
-		{
-			name:        "valid number 0 string",
-			d:           &d,
-			args:        args{[]byte(`"0"`)},
-			wantErr:     false,
-			expectedVal: 0,
-		},
-		{
-			name:        "valid number MaxInt64 string",
-			d:           &d,
-			args:        args{[]byte(fmt.Sprintf(`"%d"`, int64(math.MaxInt64)))},
-			wantErr:     false,
-			expectedVal: math.MaxInt64,
-		},
-		{
-			name:        "valid number MaxUint64 string",
-			d:           &d,
-			args:        args{[]byte(fmt.Sprintf(`"%d"`, uint64(math.MaxUint64)))},
-			wantErr:     false,
-			expectedVal: math.MaxUint64,
-		},
-	}
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			if err := tt.d.UnmarshalJSON(tt.args.input); (err != nil) != tt.wantErr {
-				t.Errorf("Decimal.UnmarshalJSON() error = %v, wantErr %v", err, tt.wantErr)
-			}
-			if !tt.wantErr && uint64(d) != tt.expectedVal {
-				t.Errorf("Decimal.UnmarshalJSON() doesn't expected:\n got %d\nwant %d", uint64(d), tt.expectedVal)
-			}
-		})
 	}
 }