forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-06-04 14:08:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Merge c9bc896a58 into 12eabbd76d

Browse source
This commit is contained in:
vickkkkkyy 2026-05-21 21:54:48 -07:00 committed by GitHub
commit 121ea240de
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
internal/ethapi/api.go
View file

@ -1902,12 +1902,6 @@ func (api *TransactionAPI) SignTransaction(ctx context.Context, args Transaction
if err != nil { if err != nil {
return nil, err return nil, err
} }
// If the transaction-to-sign was a blob transaction, then the signed one
// no longer retains the blobs, only the blob hashes. In this step, we need
// to put back the blob(s).
if args.IsEIP4844() {
signed = signed.WithBlobTxSidecar(types.NewBlobTxSidecar(sidecarVersion, args.Blobs, args.Commitments, args.Proofs))
}
data, err := signed.MarshalBinary() data, err := signed.MarshalBinary()
if err != nil { if err != nil {
return nil, err return nil, err

7
internal/ethapi/api_test.go
View file

@ -2805,10 +2805,15 @@ func TestSignBlobTransaction(t *testing.T) {
t.Fatalf("failed to fill tx defaults: %v\n", err) t.Fatalf("failed to fill tx defaults: %v\n", err)
} }
_, err = api.SignTransaction(context.Background(), argsFromTransaction(res.Tx, b.acc.Address)) result, err := api.SignTransaction(context.Background(), argsFromTransaction(res.Tx, b.acc.Address))
if err != nil { if err != nil {
t.Fatalf("should not fail on blob transaction") t.Fatalf("should not fail on blob transaction")
} }
// When no blobs are provided (only blob hashes), the signed transaction
// should not have an empty sidecar attached.
if result.Tx.BlobTxSidecar() != nil {
t.Fatal("signed transaction should not have a sidecar when no blobs were provided")
}
} }
func TestSendBlobTransaction(t *testing.T) { func TestSendBlobTransaction(t *testing.T) {