Apply suggestions from code review

This commit is contained in:
Guillaume Ballet 2025-03-23 15:01:11 +01:00 committed by GitHub
parent e4c48d1638
commit 1240a396d7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -126,10 +126,11 @@ func NewSimulatedBeacon(period uint64, feeRecipient common.Address, eth *eth.Eth
} }
} }
// cap the dev mode period to a reasonable maximum value to avoid overflowing the time.Duration (int64) that it will occupy // cap the dev mode period to a reasonable maximum value to avoid
// overflowing the time.Duration (int64) that it will occupy
maxPeriod := uint64(math.MaxInt64 / time.Second) maxPeriod := uint64(math.MaxInt64 / time.Second)
if period > maxPeriod { if period > maxPeriod {
log.Warn(fmt.Sprintf("period exceeds maximum possible value (have: %d, max: %d). Sanitizing period to maximum possible value.", period, maxPeriod)) log.Warn("sanitizing period exceeding maximum possible value", "was", period, "now", maxPeriod)
period = maxPeriod period = maxPeriod
} }