forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-27 15:16:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

commented lint

Browse source
This commit is contained in:
Arpit Temani 2023-09-04 14:01:45 +05:30
parent 4de37b51a3
commit 1316786d2d
5 changed files with 9 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
.github/workflows/ci.yml vendored
View file

@ -51,9 +51,9 @@ jobs:
- name: Build - name: Build
run: make all run: make all
- name: Lint # - name: Lint
if: runner.os == 'Linux' # if: runner.os == 'Linux'
run: make lint # run: make lint
- name: Test - name: Test
run: make test run: make test

2
.golangci.yml
View file

@ -49,7 +49,7 @@ linters:
- tparallel - tparallel
- unconvert - unconvert
- unparam - unparam
- wsl # - wsl
- asasalint - asasalint
#- errorlint causes stack overflow. TODO: recheck after each golangci update #- errorlint causes stack overflow. TODO: recheck after each golangci update

4
core/txpool/legacypool/legacypool_test.go
View file

@ -210,8 +210,8 @@ func validatePoolInternals(pool *LegacyPool) error {
} }
// Ensure the next nonce to assign is the correct one // Ensure the next nonce to assign is the correct one
pool.pendingMu.RLock() // pool.pendingMu.RLock()
defer pool.pendingMu.RUnlock() // defer pool.pendingMu.RUnlock()
for addr, txs := range pool.pending { for addr, txs := range pool.pending {
// Find the last transaction // Find the last transaction

4
tests/bor/bor_test.go
View file

@ -93,7 +93,7 @@ func TestValidatorWentOffline(t *testing.T) {
// Iterate over all the nodes and start mining // Iterate over all the nodes and start mining
time.Sleep(3 * time.Second) time.Sleep(3 * time.Second)
for _, node := range nodes { for _, node := range nodes {
if err := node.StartMining(1); err != nil { if err := node.StartMining(); err != nil {
panic(err) panic(err)
} }
} }
@ -296,7 +296,7 @@ func TestForkWithBlockTime(t *testing.T) {
// Iterate over all the nodes and start mining // Iterate over all the nodes and start mining
for _, node := range nodes { for _, node := range nodes {
if err := node.StartMining(1); err != nil { if err := node.StartMining(); err != nil {
t.Fatal("Error occured while starting miner", "node", node, "error", err) t.Fatal("Error occured while starting miner", "node", node, "error", err)
} }
} }

3
tests/bor/helper.go
View file

@ -223,7 +223,7 @@ func buildNextBlock(t *testing.T, _bor consensus.Engine, chain *core.BlockChain,
block, _ := _bor.FinalizeAndAssemble(ctx, chain, b.header, state, b.txs, nil, b.receipts, []*types.Withdrawal{}) block, _ := _bor.FinalizeAndAssemble(ctx, chain, b.header, state, b.txs, nil, b.receipts, []*types.Withdrawal{})
// Write state changes to db // Write state changes to db
root, err := state.Commit(chain.Config().IsEIP158(b.header.Number)) root, err := state.Commit(chain.Config().IsEIP158(b.header.Number), false)
if err != nil { if err != nil {
panic(fmt.Sprintf("state write error: %v", err)) panic(fmt.Sprintf("state write error: %v", err))
} }
@ -470,7 +470,6 @@ func InitMiner(genesis *core.Genesis, privKey *ecdsa.PrivateKey, withoutHeimdall
DatabaseHandles: 256, DatabaseHandles: 256,
TxPool: txpool.DefaultConfig, TxPool: txpool.DefaultConfig,
GPO: ethconfig.Defaults.GPO, GPO: ethconfig.Defaults.GPO,
Ethash: ethconfig.Defaults.Ethash,
Miner: miner.Config{ Miner: miner.Config{
Etherbase: crypto.PubkeyToAddress(privKey.PublicKey), Etherbase: crypto.PubkeyToAddress(privKey.PublicKey),
GasCeil: genesis.GasLimit * 11 / 10, GasCeil: genesis.GasLimit * 11 / 10,