From 13893feb5ca0ce64f5a84709afd06f2239f3e6b1 Mon Sep 17 00:00:00 2001 From: Guillaume Ballet <3272758+gballet@users.noreply.github.com> Date: Thu, 21 May 2026 15:38:45 +0200 Subject: [PATCH] fix tests --- cmd/geth/consolecmd_test.go | 5 ++--- cmd/geth/run_test.go | 7 +------ 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/cmd/geth/consolecmd_test.go b/cmd/geth/consolecmd_test.go index 12ee7e7dd1..2c8522d109 100644 --- a/cmd/geth/consolecmd_test.go +++ b/cmd/geth/consolecmd_test.go @@ -51,10 +51,9 @@ func runMinimalGeth(t *testing.T, args ...string) *testgeth { // then terminated by closing the input stream. func TestConsoleWelcome(t *testing.T) { t.Parallel() - coinbase := "0x8605cdbbdb6d264aa742e77020dcbc58fcdce182" // Start a geth console, make sure it's cleaned up and terminate the console - geth := runMinimalGeth(t, "--miner.etherbase", coinbase, "console") + geth := runMinimalGeth(t, "console") // Gather all the infos the welcome message needs to contain geth.SetTemplateFunc("goos", func() string { return runtime.GOOS }) @@ -98,7 +97,7 @@ func TestAttachWelcome(t *testing.T) { p := trulyRandInt(1024, 65533) // Yeah, sometimes this will fail, sorry :P httpPort = strconv.Itoa(p) wsPort = strconv.Itoa(p + 1) - geth := runMinimalGeth(t, "--miner.etherbase", "0x8605cdbbdb6d264aa742e77020dcbc58fcdce182", + geth := runMinimalGeth(t, "--ipcpath", ipc, "--http", "--http.port", httpPort, "--ws", "--ws.port", wsPort) diff --git a/cmd/geth/run_test.go b/cmd/geth/run_test.go index 1d32880325..f75e32f570 100644 --- a/cmd/geth/run_test.go +++ b/cmd/geth/run_test.go @@ -32,8 +32,7 @@ type testgeth struct { *cmdtest.TestCmd // template variables for expect - Datadir string - Etherbase string + Datadir string } func init() { @@ -75,10 +74,6 @@ func runGeth(t *testing.T, args ...string) *testgeth { if i < len(args)-1 { tt.Datadir = args[i+1] } - case "--miner.etherbase": - if i < len(args)-1 { - tt.Etherbase = args[i+1] - } } } if tt.Datadir == "" {