diff --git a/trie/bytepool.go b/trie/bytepool.go index 00b567ae1d..4f9c5672fd 100644 --- a/trie/bytepool.go +++ b/trie/bytepool.go @@ -16,7 +16,7 @@ package trie -// bytesPool is a pool for byteslices. It is safe for concurrent use. +// bytesPool is a pool for byte slices. It is safe for concurrent use. type bytesPool struct { c chan []byte w int @@ -42,6 +42,15 @@ func (bp *bytesPool) Get() []byte { } } +// GetWithSize returns a slice with specified byte slice size. +func (bp *bytesPool) GetWithSize(s int) []byte { + b := bp.Get() + if cap(b) < s { + return make([]byte, s) + } + return b[:s] +} + // Put returns a slice to the pool. Safe for concurrent use. This method // will ignore slices that are too small or too large (>3x the cap) func (bp *bytesPool) Put(b []byte) { diff --git a/trie/encoding.go b/trie/encoding.go index d795ba1895..4cd29f531a 100644 --- a/trie/encoding.go +++ b/trie/encoding.go @@ -107,12 +107,13 @@ func keybytesToHex(str []byte) []byte { // writeHexKey writes the hexkey into the given slice. // OBS! This method omits the termination flag. // OBS! The dst slice must be at least 2x as large as the key -func writeHexKey(dst []byte, key []byte) { +func writeHexKey(dst []byte, key []byte) []byte { _ = dst[2*len(key)-1] for i, b := range key { dst[i*2] = b / 16 dst[i*2+1] = b % 16 } + return dst[:2*len(key)] } // hexToKeybytes turns hex nibbles into key bytes. diff --git a/trie/node.go b/trie/node.go index 55ecfd4740..ecc2de192d 100644 --- a/trie/node.go +++ b/trie/node.go @@ -46,17 +46,23 @@ type ( hashNode []byte valueNode []byte - //fullnodeEncoder is a type used exclusively for encoding. Briefly instantiating - // a fullnodeEncoder and initializing with existing slices is less memory - // intense than using the fullNode type. + // fullnodeEncoder is a type used exclusively for encoding fullNode. + // Briefly instantiating a fullnodeEncoder and initializing with + // existing slices is less memory intense than using the fullNode type. fullnodeEncoder struct { Children [17][]byte } - //shortNodeEncoder is a type used exclusively for encoding. Briefly instantiating - // a shortNodeEncoder and initializing with existing slices is less memory - // intense than using the shortNode type. - shortNodeEncoder struct { + // extNodeEncoder is a type used exclusively for encoding extension node. + // Briefly instantiating a extNodeEncoder and initializing with existing + // slices is less memory intense than using the shortNode type. + extNodeEncoder struct { + Key []byte + Val []byte + } + + // leafNodeEncoder is a type used exclusively for encoding leaf node. + leafNodeEncoder struct { Key []byte Val []byte } diff --git a/trie/node_enc.go b/trie/node_enc.go index 5c197f07ec..7cd421b225 100644 --- a/trie/node_enc.go +++ b/trie/node_enc.go @@ -65,7 +65,7 @@ func (n *shortNode) encode(w rlp.EncoderBuffer) { w.ListEnd(offset) } -func (n *shortNodeEncoder) encode(w rlp.EncoderBuffer) { +func (n *extNodeEncoder) encode(w rlp.EncoderBuffer) { offset := w.List() w.WriteBytes(n.Key) @@ -79,6 +79,19 @@ func (n *shortNodeEncoder) encode(w rlp.EncoderBuffer) { w.ListEnd(offset) } +func (n *leafNodeEncoder) encode(w rlp.EncoderBuffer) { + offset := w.List() + + // Encode the key to Compact format. The assumption is held + // that it's safe to modify the key in place. + n.Key = append(n.Key, 16) // termination flag + n.Key = hexToCompactInPlace(n.Key) + + w.WriteBytes(n.Key) // Compact format key + w.WriteBytes(n.Val) // Value node, must be non-nil + w.ListEnd(offset) +} + func (n hashNode) encode(w rlp.EncoderBuffer) { w.WriteBytes(n) } diff --git a/trie/stacktrie.go b/trie/stacktrie.go index 99e782a78f..41992b1b7c 100644 --- a/trie/stacktrie.go +++ b/trie/stacktrie.go @@ -59,8 +59,17 @@ func NewStackTrie(onTrieNode OnTrieNode) *StackTrie { root: stPool.Get().(*stNode), h: newHasher(false), onTrieNode: onTrieNode, - kBuf: make([]byte, 0, 64), - pBuf: make([]byte, 0, 32), + kBuf: make([]byte, 64), + pBuf: make([]byte, 64), + } +} + +func (t *StackTrie) grow(key []byte) { + if cap(t.kBuf) < 2*len(key) { + t.kBuf = make([]byte, 2*len(key)) + } + if cap(t.pBuf) < len(key) { + t.pBuf = make([]byte, 2*len(key)) } } @@ -69,16 +78,8 @@ func (t *StackTrie) Update(key, value []byte) error { if len(value) == 0 { return errors.New("trying to insert empty (deletion)") } - var k []byte - { // Need to expand the 'key' into hex-form. We use the dedicated buf for that. - if cap(t.kBuf) < 2*len(key) { // realloc to ensure sufficient cap - t.kBuf = make([]byte, 2*len(key)) - } - // resize to ensure correct size - t.kBuf = t.kBuf[:2*len(key)] - writeHexKey(t.kBuf, key) - k = t.kBuf - } + t.grow(key) + k := writeHexKey(t.kBuf, key) if bytes.Compare(t.last, k) >= 0 { return errors.New("non-ascending key order") } @@ -171,6 +172,7 @@ func (n *stNode) getDiffIndex(key []byte) int { } // Helper function to that inserts a (key, value) pair into the trie. +// // - The key is not retained by this method, but always copied if needed. // - The value is retained by this method, as long as the leaf that it represents // remains unhashed. However: it is never modified. @@ -306,7 +308,7 @@ func (t *StackTrie) insert(st *stNode, key, value []byte, path []byte) { case emptyNode: /* Empty */ st.typ = leafNode - st.key = append(st.key, key...) + st.key = append(st.key, key...) // deep-copy the key as it's volatile st.val = value case hashedNode: @@ -364,7 +366,7 @@ func (t *StackTrie) hash(st *stNode, path []byte) { t.hash(st.children[0], append(path, st.key...)) // encode the extension node - n := shortNodeEncoder{ + n := extNodeEncoder{ Key: hexToCompactInPlace(st.key), Val: st.children[0].val, } @@ -375,14 +377,11 @@ func (t *StackTrie) hash(st *stNode, path []byte) { st.children[0] = nil case leafNode: - st.key = append(st.key, byte(16)) - { - w := t.h.encbuf - offset := w.List() - w.WriteBytes(hexToCompactInPlace(st.key)) - w.WriteBytes(st.val) - w.ListEnd(offset) + n := leafNodeEncoder{ + Key: st.key, + Val: st.val, } + n.encode(t.h.encbuf) blob = t.h.encodedBytes() default: @@ -397,18 +396,14 @@ func (t *StackTrie) hash(st *stNode, path []byte) { // Skip committing the non-root node if the size is smaller than 32 bytes // as tiny nodes are always embedded in their parent except root node. if len(blob) < 32 && len(path) > 0 { - val := bPool.Get() - val = val[:len(blob)] - copy(val, blob) - st.val = val + st.val = bPool.GetWithSize(len(blob)) + copy(st.val, blob) return } // Write the hash to the 'val'. We allocate a new val here to not mutate // input values. - val := bPool.Get() - val = val[:32] - t.h.hashDataTo(val, blob) - st.val = val + st.val = bPool.GetWithSize(32) + t.h.hashDataTo(st.val, blob) // Invoke the callback it's provided. Notably, the path and blob slices are // volatile, please deep-copy the slices in callback if the contents need