From 1415bb63695780d26924f1a696c3a4f42a41a80f Mon Sep 17 00:00:00 2001
From: Daniel Liu <liudaniel@qq.com>
Date: Fri, 13 Dec 2024 14:00:12 +0800
Subject: [PATCH] metrics: add missing calls to Ticker.Stop in tests (#20866)

---
 metrics/meter_test.go  | 1 +
 metrics/sample_test.go | 1 +
 2 files changed, 2 insertions(+)

diff --git a/metrics/meter_test.go b/metrics/meter_test.go
index 0dfce76b7a..37e45bded2 100644
--- a/metrics/meter_test.go
+++ b/metrics/meter_test.go
@@ -26,6 +26,7 @@ func TestMeterDecay(t *testing.T) {
 		ticker: time.NewTicker(time.Millisecond),
 		meters: make(map[*StandardMeter]struct{}),
 	}
+	defer ma.ticker.Stop()
 	m := newStandardMeter()
 	ma.meters[m] = struct{}{}
 	go ma.tick()
diff --git a/metrics/sample_test.go b/metrics/sample_test.go
index be7bf3d2df..5b2ee96e36 100644
--- a/metrics/sample_test.go
+++ b/metrics/sample_test.go
@@ -346,6 +346,7 @@ func TestUniformSampleConcurrentUpdateCount(t *testing.T) {
 	quit := make(chan struct{})
 	go func() {
 		t := time.NewTicker(10 * time.Millisecond)
+		defer t.Stop()
 		for {
 			select {
 			case <-t.C: