core/vm: more linters (#24783)

This commit is contained in:
Daniel Liu 2024-09-25 10:15:14 +08:00 committed by Daniel Liu
parent be6631beb0
commit 16f2aabc64
2 changed files with 24 additions and 26 deletions

View file

@ -29,8 +29,6 @@ import (
"github.com/XinFinOrg/XDPoSChain/crypto/blake2b" "github.com/XinFinOrg/XDPoSChain/crypto/blake2b"
"github.com/XinFinOrg/XDPoSChain/crypto/bn256" "github.com/XinFinOrg/XDPoSChain/crypto/bn256"
"github.com/XinFinOrg/XDPoSChain/params" "github.com/XinFinOrg/XDPoSChain/params"
//lint:ignore SA1019 Needed for precompile
"golang.org/x/crypto/ripemd160" "golang.org/x/crypto/ripemd160"
) )

View file

@ -230,8 +230,13 @@ func TestAddMod(t *testing.T) {
} }
} }
// getResult is a convenience function to generate the expected values // utility function to fill the json-file with testcases
func getResult(args []*twoOperandParams, opFn executionFunc) []TwoOperandTestcase { // Enable this test to generate the 'testcases_xx.json' files
func TestWriteExpectedValues(t *testing.T) {
t.Skip("Enable this test to create json test cases.")
// getResult is a convenience function to generate the expected values
getResult := func(args []*twoOperandParams, opFn executionFunc) []TwoOperandTestcase {
var ( var (
env = NewEVM(BlockContext{}, TxContext{}, nil, nil, params.TestChainConfig, Config{}) env = NewEVM(BlockContext{}, TxContext{}, nil, nil, params.TestChainConfig, Config{})
stack = newstack() stack = newstack()
@ -252,12 +257,7 @@ func getResult(args []*twoOperandParams, opFn executionFunc) []TwoOperandTestcas
result[i] = TwoOperandTestcase{param.x, param.y, fmt.Sprintf("%064x", actual)} result[i] = TwoOperandTestcase{param.x, param.y, fmt.Sprintf("%064x", actual)}
} }
return result return result
} }
// utility function to fill the json-file with testcases
// Enable this test to generate the 'testcases_xx.json' files
func TestWriteExpectedValues(t *testing.T) {
t.Skip("Enable this test to create json test cases.")
for name, method := range twoOpMethods { for name, method := range twoOpMethods {
data, err := json.Marshal(getResult(commonParams, method)) data, err := json.Marshal(getResult(commonParams, method))