forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-24 21:56:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

rpc: increased log level in case RPC request could not be read

Browse source
This commit is contained in:
Bas van Kervel 2016-04-15 11:45:50 +02:00
parent 5f917715c5
commit 1746e2ddbd
3 changed files with 24 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
rpc/errors.go
View file

@ -18,6 +18,11 @@ package rpc
import "fmt"
var (
// ErrConnectionClosed is thrown when the connection is closed
ErrConnectionClosed = new(connectionClosedError)
)
// request is for an unknown service
type methodNotFoundError struct {
service string
@ -95,3 +100,15 @@ func (e *shutdownError) Code() int {
func (e *shutdownError) Error() string {
return "server is shutting down"
}
// connectionClosedError is thrown when the connection is closed
type connectionClosedError struct {
}
func (e *connectionClosedError) Code() int {
return 0
}
func (e *connectionClosedError) Error() string {
return "connection closed"
}

3
rpc/json.go
View file

@ -119,6 +119,9 @@ func (c *jsonCodec) ReadRequestHeaders() ([]rpcRequest, bool, RPCError) {
var incomingMsg json.RawMessage
if err := c.d.Decode(&incomingMsg); err != nil {
if err == io.EOF {
return nil, false, ErrConnectionClosed
}
return nil, false, &invalidRequestError{err.Error()}
}

6
rpc/server.go
View file

@ -185,8 +185,10 @@ func (s *Server) serveRequest(codec ServerCodec, singleShot bool, options CodecO
for atomic.LoadInt32(&s.run) == 1 {
reqs, batch, err := s.readRequest(codec)
if err != nil {
glog.V(logger.Debug).Infof("%v\n", err)
codec.Write(codec.CreateErrorResponse(nil, err))
if err != ErrConnectionClosed {
glog.V(logger.Error).Infof("%v\n", err)
codec.Write(codec.CreateErrorResponse(nil, err))
}
return nil
}