node: require LocalAppData variable

This avoids path inconsistencies on Windows XP.
Hat tip to @MicahZoltu for catching this so quickly.
This commit is contained in:
Felix Lange 2019-02-19 13:53:22 +01:00
parent f1537b774c
commit 17d2ba5508

View file

@ -80,13 +80,14 @@ func DefaultDataDir() string {
} }
func windowsAppData() string { func windowsAppData() string {
if v := os.Getenv("LOCALAPPDATA"); v != "" { v := os.Getenv("LOCALAPPDATA")
return v // Vista+ if v == "" {
// Windows XP and below don't have LocalAppData. Crash here because
// we don't support Windows XP and undefining the variable will cause
// other issues.
panic("environment varibale LocalAppData is undefined")
} }
if v := os.Getenv("APPDATA"); v != "" { return v
return filepath.Join(v, "Local")
}
return ""
} }
func isNonEmptyDir(dir string) bool { func isNonEmptyDir(dir string) bool {