From 17ddd470fb1108854a1d97ff564f871c160f382e Mon Sep 17 00:00:00 2001
From: maskpp <maskpp266@gmail.com>
Date: Mon, 17 Jun 2024 10:22:22 +0800
Subject: [PATCH] revert unnecessary change

---
 core/state/snapshot/difflayer.go | 11 +++++------
 core/state/snapshot/snapshot.go  | 10 +++++++---
 2 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/core/state/snapshot/difflayer.go b/core/state/snapshot/difflayer.go
index 93bf7d2d70..779c1ea98c 100644
--- a/core/state/snapshot/difflayer.go
+++ b/core/state/snapshot/difflayer.go
@@ -525,20 +525,19 @@ func (dl *diffLayer) StorageList(accountHash common.Hash) ([]common.Hash, bool)
 		dl.lock.RUnlock()
 		return list, destructed // the cached list can't be nil
 	}
-	storageMap := dl.storageData[accountHash]
 	dl.lock.RUnlock()
 
+	// No old sorted account list exists, generate a new one
+	dl.lock.Lock()
+	defer dl.lock.Unlock()
+
+	storageMap := dl.storageData[accountHash]
 	storageList := make([]common.Hash, 0, len(storageMap))
 	for k := range storageMap {
 		storageList = append(storageList, k)
 	}
 	slices.SortFunc(storageList, common.Hash.Cmp)
-
-	// No old sorted account list exists, generate a new one
-	dl.lock.Lock()
 	dl.storageList[accountHash] = storageList
 	dl.memory += uint64(len(dl.storageList)*common.HashLength + common.HashLength)
-	dl.lock.Unlock()
-
 	return storageList, destructed
 }
diff --git a/core/state/snapshot/snapshot.go b/core/state/snapshot/snapshot.go
index d9d8997d86..7c76765417 100644
--- a/core/state/snapshot/snapshot.go
+++ b/core/state/snapshot/snapshot.go
@@ -818,12 +818,10 @@ func (t *Tree) Verify(root common.Hash) error {
 // The lock of snapTree is assumed to be held already.
 func (t *Tree) disklayer() *diskLayer {
 	var snap snapshot
-	t.lock.RLock()
 	for _, s := range t.layers {
 		snap = s
 		break
 	}
-	t.lock.RUnlock()
 	if snap == nil {
 		return nil
 	}
@@ -852,6 +850,9 @@ func (t *Tree) diskRoot() common.Hash {
 // generating is an internal helper function which reports whether the snapshot
 // is still under the construction.
 func (t *Tree) generating() (bool, error) {
+	t.lock.Lock()
+	defer t.lock.Unlock()
+
 	layer := t.disklayer()
 	if layer == nil {
 		return false, errors.New("disk layer is missing")
@@ -861,8 +862,11 @@ func (t *Tree) generating() (bool, error) {
 	return layer.genMarker != nil, nil
 }
 
-// DiskRoot is a external helper function to return the disk layer root.
+// DiskRoot is an external helper function to return the disk layer root.
 func (t *Tree) DiskRoot() common.Hash {
+	t.lock.Lock()
+	defer t.lock.Unlock()
+
 	return t.diskRoot()
 }