forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-06-19 21:31:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

core/txpool: use right type for field Txs in NewTxsEvent (#1897)

Browse source 
This commit updates the Txs field in NewTxsEvent to use []*types.Transaction instead of types.Transactions. This ensures type consistency for event broadcasting and handling, improving reliability of transaction propagation across the network. The change also removes unnecessary goroutine usage for txFeed.Send, making event delivery synchronous and safer for downstream consumers.
This commit is contained in:
Daniel Liu 2026-01-05 14:42:28 +08:00 committed by GitHub
parent 3fb8b87a87
commit 1886219894
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
core/txpool/txpool.go
View file

@ -971,7 +971,7 @@ func (pool *TxPool) promoteSpecialTx(addr common.Address, tx *types.Transaction,
// Set the potentially new pending nonce and notify any subsystems of the new tx
pool.beats[addr] = time.Now()
pool.pendingNonces.set(addr, tx.Nonce()+1)
go pool.txFeed.Send(core.NewTxsEvent{Txs: types.Transactions{tx}})
pool.txFeed.Send(core.NewTxsEvent{Txs: []*types.Transaction{tx}})
return true, nil
}