forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-06-19 21:31:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

resolve conflict

Browse source
This commit is contained in:
Liam Lai 2023-08-25 16:11:33 +10:00
commit 1a2e457b7a
1 changed files with 13 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
.github/pull_request_template.md vendored
View file

@ -1,14 +1,10 @@
## Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue(or XIP) or explain it in the pull request.
You description should at least include below key points:
- Proposed version bump. i.e Major, Minor or patch
- Proposed release date to testnet and mainnet
# Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
## Types of changes
What types of changes does your code introduce to XDC network?
_Put an `x` in the boxes that apply_
_Put an `✅` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
@ -18,25 +14,24 @@ _Put an `x` in the boxes that apply_
- [ ] CICD Improvement
## Impacted Components
Which part of the codebase this PR will touch base on,
_Put an `x` in the boxes that apply_
_Put an `✅` in the boxes that apply_
- [ ] Consensus
- [ ] Geth
- [ ] Network
- [ ] Smart Contract
- [ ] EVM
- [ ] Account
- [ ] Not sure
- [ ] N/A
- [ ] Network
- [ ] Geth
- [ ] Smart Contract
- [ ] External components
- [ ] Not sure (Please specify below)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
_Put an `✅` in the boxes once you have confirmed below actions (or provide reasons on not doing so) that_
- [ ] This PR have sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
- [ ] This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
- [ ] Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
- [ ] Tested the backwards compatibility.
- [ ] Tested with XDC nodes running this version co-exist with those running the previous version.
- [ ] Relevant documentation has been updated as part of this PR
- [ ] N/A
- [ ] N/A