forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-20 10:52:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix #482: Ignore order of masternodes list

Browse source
This commit is contained in:
NguyenNguyen 2019-04-04 11:06:50 +07:00
parent 5d3c8265e4
commit 1a51d2d34c
1 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
consensus/posv/posv.go
View file

@ -25,6 +25,8 @@ import (
"math/big" "math/big"
"math/rand" "math/rand"
"path/filepath" "path/filepath"
"reflect"
"sort"
"strconv" "strconv"
"sync" "sync"
"time" "time"
@ -424,9 +426,18 @@ func (c *Posv) verifyCascadingFields(chain consensus.ChainReader, header *types.
signers = RemovePenaltiesFromBlock(chain, signers, number-uint64(i)*c.config.Epoch) signers = RemovePenaltiesFromBlock(chain, signers, number-uint64(i)*c.config.Epoch)
} }
} }
byteMasterNodes := common.ExtractAddressToBytes(signers)
extraSuffix := len(header.Extra) - extraSeal extraSuffix := len(header.Extra) - extraSeal
if !bytes.Equal(header.Extra[extraVanity:extraSuffix], byteMasterNodes) { masternodesFromCheckpointHeader := common.ExtractAddressFromBytes(header.Extra[extraVanity:extraSuffix])
validSigners := true
sort.Slice(masternodesFromCheckpointHeader, func(i, j int) bool {
return masternodesFromCheckpointHeader[i].String() <= masternodesFromCheckpointHeader[j].String()
})
sort.Slice(signers, func(i, j int) bool {
return signers[i].String() <= signers[j].String()
})
validSigners = reflect.DeepEqual(masternodesFromCheckpointHeader, signers)
if !validSigners {
log.Error("Masternodes lists are different in checkpoint header and snapshot", "number", number, "masternodes_from_checkpoint_header", masternodesFromCheckpointHeader, "masternodes_in_snapshot", signers, "penList", penPenalties)
return errInvalidCheckpointSigners return errInvalidCheckpointSigners
} }
if c.HookVerifyMNs != nil { if c.HookVerifyMNs != nil {