triedb/pathdb: use copy instead of append to reduce memory alloc (#33044)

triedb/pathdb/disklayer.go

@@ -275,7 +275,7 @@ func (dl *diskLayer) storage(accountHash, storageHash common.Hash, depth int) ([
 
 	// If the layer is being generated, ensure the requested storage slot
 	// has already been covered by the generator.
-	key := append(accountHash[:], storageHash[:]...)
+	key := storageKeySlice(accountHash, storageHash)
 	marker := dl.genMarker()
 	if marker != nil && bytes.Compare(key, marker) > 0 {
 		return nil, errNotCoveredYet

triedb/pathdb/flush.go

@@ -116,15 +116,16 @@ func writeStates(batch ethdb.Batch, genMarker []byte, accountData map[common.Has
 				continue
 			}
 			slots += 1
+			key := storageKeySlice(addrHash, storageHash)
 			if len(blob) == 0 {
 				rawdb.DeleteStorageSnapshot(batch, addrHash, storageHash)
 				if clean != nil {
-					clean.Set(append(addrHash[:], storageHash[:]...), nil)
+					clean.Set(key, nil)
 				}
 			} else {
 				rawdb.WriteStorageSnapshot(batch, addrHash, storageHash, blob)
 				if clean != nil {
-					clean.Set(append(addrHash[:], storageHash[:]...), blob)
+					clean.Set(key, blob)
 				}
 			}
 		}

triedb/pathdb/lookup.go

@@ -33,6 +33,13 @@ func storageKey(accountHash common.Hash, slotHash common.Hash) [64]byte {
 	return key
 }
 
+// storageKeySlice returns a key for uniquely identifying the storage slot in
+// the slice format.
+func storageKeySlice(accountHash common.Hash, slotHash common.Hash) []byte {
+	key := storageKey(accountHash, slotHash)
+	return key[:]
+}
+
 // lookup is an internal structure used to efficiently determine the layer in
 // which a state entry resides.
 type lookup struct {