From 1d653e57abf70a4277dc184e3cac97e2a8b01b4f Mon Sep 17 00:00:00 2001
From: Daniel Liu <liudaniel@qq.com>
Date: Tue, 18 Feb 2025 19:34:17 +0800
Subject: [PATCH] cmd, core: merge flags testnet and apothem

---
 cmd/XDC/chaincmd.go |  8 ++++----
 cmd/XDC/config.go   |  2 +-
 cmd/XDC/main.go     |  3 +--
 cmd/utils/flags.go  | 24 +++++++-----------------
 core/genesis.go     |  4 +---
 5 files changed, 14 insertions(+), 27 deletions(-)

diff --git a/cmd/XDC/chaincmd.go b/cmd/XDC/chaincmd.go
index 84dac53598..2b4dc5941c 100644
--- a/cmd/XDC/chaincmd.go
+++ b/cmd/XDC/chaincmd.go
@@ -45,7 +45,7 @@ var (
 			utils.DataDirFlag,
 			utils.XDCXDataDirFlag,
 			utils.LightModeFlag,
-			utils.XDCTestnetFlag,
+			utils.TestnetFlag,
 		},
 		Description: `
 The init command initializes a new genesis block and definition for the network.
@@ -156,9 +156,9 @@ Use "ethereum dump 0" to dump the genesis block.`,
 func initGenesis(ctx *cli.Context) error {
 	var err error
 	genesis := new(core.Genesis)
-	if ctx.Bool(utils.XDCTestnetFlag.Name) {
+	if ctx.Bool(utils.TestnetFlag.Name) {
 		if ctx.Args().Len() > 0 {
-			utils.Fatalf("Flags --apothem and genesis file can't be used at the same time")
+			utils.Fatalf("The testnet flag and genesis file can't be used at the same time")
 		}
 		err = json.Unmarshal(xdc_genesis.TestnetGenesis, &genesis)
 	} else {
@@ -168,7 +168,7 @@ func initGenesis(ctx *cli.Context) error {
 		genesisPath := ctx.Args().First()
 		if genesisPath == "mainnet" {
 			err = json.Unmarshal(xdc_genesis.MainnetGenesis, &genesis)
-		} else if genesisPath == "testnet" {
+		} else if genesisPath == "testnet" || genesisPath == "apothem" {
 			err = json.Unmarshal(xdc_genesis.TestnetGenesis, &genesis)
 		} else if genesisPath == "devnet" {
 			err = json.Unmarshal(xdc_genesis.DevnetGenesis, &genesis)
diff --git a/cmd/XDC/config.go b/cmd/XDC/config.go
index 38ff730bdf..b5e22c12e9 100644
--- a/cmd/XDC/config.go
+++ b/cmd/XDC/config.go
@@ -157,7 +157,7 @@ func makeConfigNode(ctx *cli.Context) (*node.Node, XDCConfig) {
 	}
 
 	// Check testnet is enable.
-	if ctx.Bool(utils.XDCTestnetFlag.Name) {
+	if ctx.Bool(utils.TestnetFlag.Name) {
 		common.IsTestnet = true
 		common.TRC21IssuerSMC = common.TRC21IssuerSMCTestNet
 		cfg.Eth.NetworkId = 51
diff --git a/cmd/XDC/main.go b/cmd/XDC/main.go
index d87f5e2b61..f8c85e4746 100644
--- a/cmd/XDC/main.go
+++ b/cmd/XDC/main.go
@@ -117,10 +117,9 @@ var (
 		utils.NodeKeyHexFlag,
 		//utils.DeveloperFlag,
 		//utils.DeveloperPeriodFlag,
-		//utils.TestnetFlag,
+		utils.TestnetFlag,
 		//utils.RinkebyFlag,
 		//utils.VMEnableDebugFlag,
-		utils.XDCTestnetFlag,
 		utils.Enable0xPrefixFlag,
 		utils.EnableXDCPrefixFlag,
 		utils.RewoundFlag,
diff --git a/cmd/utils/flags.go b/cmd/utils/flags.go
index 569144c246..b781c20947 100644
--- a/cmd/utils/flags.go
+++ b/cmd/utils/flags.go
@@ -106,12 +106,8 @@ var (
 	}
 	TestnetFlag = &cli.BoolFlag{
 		Name:     "testnet",
-		Usage:    "Ropsten network: pre-configured proof-of-work test network",
-		Category: flags.EthCategory,
-	}
-	XDCTestnetFlag = &cli.BoolFlag{
-		Name:     "apothem",
-		Usage:    "XDC Apothem Network",
+		Aliases:  []string{"apothem"},
+		Usage:    "XDC apothem network",
 		Category: flags.EthCategory,
 	}
 	RinkebyFlag = &cli.BoolFlag{
@@ -883,14 +879,11 @@ func setBootstrapNodes(ctx *cli.Context, cfg *p2p.Config) {
 		if cfg.BootstrapNodes != nil {
 			return // Already set by config file, don't apply defaults.
 		}
-		networkID := uint64(0)
-		if ctx.IsSet(NetworkIdFlag.Name) {
-			networkID = ctx.Uint64(NetworkIdFlag.Name)
-		}
+		networkID := ctx.Uint64(NetworkIdFlag.Name)
 		switch {
-		case ctx.Bool(XDCTestnetFlag.Name) || networkID == params.TestnetChainConfig.ChainId.Uint64():
+		case ctx.Bool(TestnetFlag.Name) || networkID == 51:
 			urls = params.TestnetBootnodes
-		case networkID == params.DevnetChainConfig.ChainId.Uint64():
+		case networkID == 551:
 			urls = params.DevnetBootnodes
 		}
 	}
@@ -921,7 +914,7 @@ func setBootstrapNodesV5(ctx *cli.Context, cfg *p2p.Config) {
 		urls = SplitAndTrim(ctx.String(BootnodesFlag.Name))
 	case ctx.IsSet(BootnodesV5Flag.Name):
 		urls = SplitAndTrim(ctx.String(BootnodesV5Flag.Name))
-	case ctx.Bool(XDCTestnetFlag.Name):
+	case ctx.Bool(TestnetFlag.Name):
 		urls = params.TestnetBootnodes
 	case cfg.BootstrapNodesV5 != nil:
 		return // already set, don't apply defaults.
@@ -1443,9 +1436,6 @@ func SetEthConfig(ctx *cli.Context, stack *node.Node, cfg *ethconfig.Config) {
 	if ctx.IsSet(NetworkIdFlag.Name) {
 		cfg.NetworkId = ctx.Uint64(NetworkIdFlag.Name)
 	}
-	if ctx.Bool(XDCTestnetFlag.Name) {
-		cfg.NetworkId = 51
-	}
 
 	if ctx.IsSet(CacheFlag.Name) || ctx.IsSet(CacheDatabaseFlag.Name) {
 		cfg.DatabaseCache = ctx.Int(CacheFlag.Name) * ctx.Int(CacheDatabaseFlag.Name) / 100
@@ -1501,7 +1491,7 @@ func SetEthConfig(ctx *cli.Context, stack *node.Node, cfg *ethconfig.Config) {
 	switch {
 	case ctx.Bool(TestnetFlag.Name):
 		if !ctx.IsSet(NetworkIdFlag.Name) {
-			cfg.NetworkId = 3
+			cfg.NetworkId = 51
 		}
 		cfg.Genesis = core.DefaultTestnetGenesisBlock()
 	case ctx.Bool(RinkebyFlag.Name):
diff --git a/core/genesis.go b/core/genesis.go
index 2540b99afb..224a47f143 100644
--- a/core/genesis.go
+++ b/core/genesis.go
@@ -281,10 +281,8 @@ func DefaultGenesisBlock() *Genesis {
 	}
 }
 
-// DefaultTestnetGenesisBlock returns the Ropsten network genesis block.
+// DefaultTestnetGenesisBlock returns the XDC testnet genesis block.
 func DefaultTestnetGenesisBlock() *Genesis {
-	config := params.TestnetChainConfig
-	config.XDPoS.V2 = nil
 	return &Genesis{
 		Config:     params.TestnetChainConfig,
 		Nonce:      0,