forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-22 04:36:42 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

eth/catalyst: always reset timer after sealing error (#33146)

Browse source 
The periodic sealing loop failed to reset its timer when sealBlock
returned an error, causing the timer to never fire again and effectively
halting block production in developer periodic mode after the first
failure. This is a bug because the loop relies on the timer to trigger
subsequent sealing attempts, and transient errors (e.g., pool races or
chain rewinds) should not permanently stop the loop. The change moves
timer.Reset after the sealing attempt unconditionally, ensuring the loop
continues ticking and retrying even when sealing fails, which matches
how other periodic timers in the codebase behave and preserves forward
progress.
This commit is contained in:
sashass1315 2025-11-10 19:44:31 +02:00 committed by Alvarez
parent cd45794c1c
commit 1fdba72f5c
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
eth/catalyst/simulated_beacon.go
View file

@ -280,9 +280,8 @@ func (c *SimulatedBeacon) loop() {
case <-timer.C: case <-timer.C:
if err := c.sealBlock(c.withdrawals.pop(10), uint64(time.Now().Unix())); err != nil { if err := c.sealBlock(c.withdrawals.pop(10), uint64(time.Now().Unix())); err != nil {
log.Warn("Error performing sealing work", "err", err) log.Warn("Error performing sealing work", "err", err)
} else {
timer.Reset(time.Second * time.Duration(c.period))
} }
timer.Reset(time.Second * time.Duration(c.period))
} }
} }
} }