Merge branch 'master' into multiplex-ws-rpc

This commit is contained in:
renaynay 2020-03-27 14:02:58 +01:00
commit 2321f64d69
No known key found for this signature in database
GPG key ID: 731E44FAAFCD0274
3 changed files with 5 additions and 6 deletions

View file

@ -158,7 +158,7 @@ func (n *Node) Register(constructor ServiceConstructor) error {
return nil
}
// Start create a live P2P node and starts running it.
// Start creates a live P2P node and starts running it.
func (n *Node) Start() error {
n.lock.Lock()
defer n.lock.Unlock()
@ -235,7 +235,7 @@ func (n *Node) Start() error {
// Mark the service started for potential cleanup
started = append(started, kind)
}
// Lastly start the configured RPC interfaces
// Lastly, start the configured RPC interfaces
if err := n.startRPC(services); err != nil {
for _, service := range services {
service.Stop()
@ -274,7 +274,7 @@ func (n *Node) openDataDir() error {
return nil
}
// startRPC is a helper method to start all the various RPC endpoint during node
// startRPC is a helper method to start all the various RPC endpoints during node
// startup. It's not meant to be called at any time afterwards as it makes certain
// assumptions about the state of the node.
func (n *Node) startRPC(services map[reflect.Type]Service) error {

View file

@ -107,7 +107,6 @@ func StartWSEndpoint(endpoint string, apis []API, modules []string, wsOrigins []
}
go NewWSServer(wsOrigins, handler).Serve(listener)
return listener, handler, err
}
// StartIPCEndpoint starts an IPC endpoint.

View file

@ -214,8 +214,8 @@ func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) {
http.Error(w, err.Error(), code)
return
}
// All checks passed, create a codec that reads direct from the request body
// until EOF, write the response to w, and order the server to process a
// All checks passed, create a codec that reads directly from the request body
// until EOF, writes the response to w, and orders the server to process a
// single request.
ctx := r.Context()
ctx = context.WithValue(ctx, "remote", r.RemoteAddr)