From 23c6c034d6edd869ec6f697fe3b3ec7eaba6f19e Mon Sep 17 00:00:00 2001 From: Zach Ramsay Date: Tue, 12 Dec 2017 13:42:54 +0000 Subject: [PATCH] lints: gotta catch em all --- cmd/swarm/config.go | 2 +- cmd/swarm/config_test.go | 8 ++++---- swarm/api/config_test.go | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/cmd/swarm/config.go b/cmd/swarm/config.go index ec81bc741b..33235ca06e 100644 --- a/cmd/swarm/config.go +++ b/cmd/swarm/config.go @@ -267,7 +267,7 @@ func envVarsOverride(currentConfig *bzzapi.Config) (config *bzzapi.Config) { } //EnsApi can be set to "", so can't check for empty string, as it is allowed - if ensapi, exists := os.LookupEnv(SWARM_ENV_ENS_API); exists == true { + if ensapi, exists := os.LookupEnv(SWARM_ENV_ENS_API); exists { currentConfig.EnsApi = ensapi } diff --git a/cmd/swarm/config_test.go b/cmd/swarm/config_test.go index 7ffe2cfb97..166980d148 100644 --- a/cmd/swarm/config_test.go +++ b/cmd/swarm/config_test.go @@ -124,7 +124,7 @@ func TestCmdLineOverrides(t *testing.T) { t.Fatalf("Expected network ID to be %d, got %d", 42, info.NetworkId) } - if info.SyncEnabled != true { + if !info.SyncEnabled { t.Fatal("Expected Sync to be enabled, but is false") } @@ -219,7 +219,7 @@ func TestFileOverrides(t *testing.T) { t.Fatalf("Expected network ID to be %d, got %d", 54, info.NetworkId) } - if info.SyncEnabled != true { + if !info.SyncEnabled { t.Fatal("Expected Sync to be enabled, but is false") } @@ -334,7 +334,7 @@ func TestEnvVars(t *testing.T) { t.Fatalf("Expected Cors flag to be set to %s, got %s", "*", info.Cors) } - if info.SyncEnabled != true { + if !info.SyncEnabled { t.Fatal("Expected Sync to be enabled, but is false") } @@ -431,7 +431,7 @@ func TestCmdLineOverridesFile(t *testing.T) { t.Fatalf("Expected network ID to be %d, got %d", expectNetworkId, info.NetworkId) } - if info.SyncEnabled != true { + if !info.SyncEnabled { t.Fatal("Expected Sync to be enabled, but is false") } diff --git a/swarm/api/config_test.go b/swarm/api/config_test.go index 2e03a610e1..5636b6dafb 100644 --- a/swarm/api/config_test.go +++ b/swarm/api/config_test.go @@ -36,7 +36,7 @@ func TestConfig(t *testing.T) { one := NewDefaultConfig() two := NewDefaultConfig() - if equal := reflect.DeepEqual(one, two); equal == false { + if equal := reflect.DeepEqual(one, two); !equal { t.Fatal("Two default configs are not equal") }