diff --git a/cmd/clef/main.go b/cmd/clef/main.go index dde4ae853f..99bfeac4d2 100644 --- a/cmd/clef/main.go +++ b/cmd/clef/main.go @@ -923,13 +923,13 @@ func testExternalUI(api *core.SignerAPI) { } } expectApprove := func(testcase string, err error) { - if err == nil || err == accounts.ErrUnknownAccount { + if err == nil || errors.Is(err, accounts.ErrUnknownAccount) { return } addErr(fmt.Sprintf("%v: expected no error, got %v", testcase, err.Error())) } expectDeny := func(testcase string, err error) { - if err == nil || err != core.ErrRequestDenied { + if err == nil || !errors.Is(err, core.ErrRequestDenied) { addErr(fmt.Sprintf("%v: expected ErrRequestDenied, got %v", testcase, err)) } } diff --git a/cmd/devp2p/internal/ethtest/chain.go b/cmd/devp2p/internal/ethtest/chain.go index a90c53c432..8c000cdb2a 100644 --- a/cmd/devp2p/internal/ethtest/chain.go +++ b/cmd/devp2p/internal/ethtest/chain.go @@ -271,7 +271,7 @@ func blocksFromFile(chainfile string, gblock *types.Block) ([]*types.Block, erro blocks[0] = gblock for i := 0; ; i++ { var b types.Block - if err := stream.Decode(&b); err == io.EOF { + if err := stream.Decode(&b); errors.Is(err, io.EOF) { break } else if err != nil { return nil, fmt.Errorf("at block index %d: %v", i, err) diff --git a/cmd/devp2p/internal/v5test/discv5tests.go b/cmd/devp2p/internal/v5test/discv5tests.go index 7dbd3c3be5..6213bf0931 100644 --- a/cmd/devp2p/internal/v5test/discv5tests.go +++ b/cmd/devp2p/internal/v5test/discv5tests.go @@ -18,6 +18,7 @@ package v5test import ( "bytes" + "errors" "net" "slices" "sync" @@ -96,7 +97,7 @@ func (s *Suite) TestPingLargeRequestID(t *utesting.T) { case *v5wire.Pong: t.Errorf("PONG response with unknown request ID %x", resp.ReqID) case *readError: - if resp.err == v5wire.ErrInvalidReqID { + if errors.Is(resp.err, v5wire.ErrInvalidReqID) { t.Error("response with oversized request ID") } else if !netutil.IsTimeout(resp.err) { t.Error(resp) diff --git a/cmd/rlpdump/main.go b/cmd/rlpdump/main.go index 685e5bb71a..baefafad10 100644 --- a/cmd/rlpdump/main.go +++ b/cmd/rlpdump/main.go @@ -22,6 +22,7 @@ import ( "bytes" "container/list" "encoding/hex" + "errors" "flag" "fmt" "io" @@ -149,7 +150,7 @@ func dump(in *inStream, s *rlp.Stream, depth int, out io.Writer) error { if i > 0 { fmt.Fprint(out, ",\n") } - if err := dump(in, s, depth+1, out); err == rlp.EOL { + if err := dump(in, s, depth+1, out); errors.Is(err, rlp.EOL) { break } else if err != nil { return err diff --git a/cmd/utils/cmd.go b/cmd/utils/cmd.go index de5918a722..5fab5a695a 100644 --- a/cmd/utils/cmd.go +++ b/cmd/utils/cmd.go @@ -196,7 +196,7 @@ func ImportChain(chain *core.BlockChain, fn string) error { i := 0 for ; i < importBatchSize; i++ { var b types.Block - if err := stream.Decode(&b); err == io.EOF { + if err := stream.Decode(&b); errors.Is(err, io.EOF) { break } else if err != nil { return fmt.Errorf("at block %d: %v", n, err) @@ -517,7 +517,7 @@ func ImportPreimages(db ethdb.Database, fn string) error { var blob []byte if err := stream.Decode(&blob); err != nil { - if err == io.EOF { + if errors.Is(err, io.EOF) { break } return err @@ -727,7 +727,7 @@ func ImportLDBData(db ethdb.Database, f string, startIndex int64, interrupt chan key, val []byte ) if err := stream.Decode(&op); err != nil { - if err == io.EOF { + if errors.Is(err, io.EOF) { break } return err diff --git a/eth/api_admin.go b/eth/api_admin.go index 4a3ccb84e8..a1c222bf9b 100644 --- a/eth/api_admin.go +++ b/eth/api_admin.go @@ -113,7 +113,7 @@ func (api *AdminAPI) ImportChain(file string) (bool, error) { // Load a batch of blocks from the input file for len(blocks) < cap(blocks) { block := new(types.Block) - if err := stream.Decode(block); err == io.EOF { + if err := stream.Decode(block); errors.Is(err, io.EOF) { break } else if err != nil { return false, fmt.Errorf("block %d: failed to parse: %v", index, err)