core, eth: Only show rejections if err is not nil

core/tx_pool.go

@@ -853,10 +853,12 @@ func (pool *TxPool) addTxs(txs []*types.Transaction, local, sync bool) []error {
 		for errs[nilSlot] != nil {
 			nilSlot++
 		}
+		if err != nil {
 			pool.rejectTxFeed.Send(RejectedTxEvent{
 				Tx: txs[nilSlot],
 				Reason: err,
 			})
+		}
 		errs[nilSlot] = err
 	}
 	// Reorg the pool internals if needed and return

eth/filters/dropped_tx_subscription.go

@@ -15,7 +15,7 @@ type dropNotification struct {
 }
 
 type rejectNotification struct {
-	Tx *types.Transaction
+	Tx *types.Transaction `json:"tx"`
 	Reason string `json:"reason"`
 }
 
@@ -67,7 +67,11 @@ func (api *PublicFilterAPI) RejectedTransactions(ctx context.Context) (*rpc.Subs
 		for {
 			select {
 			case d := <-rejected:
-				notifier.Notify(rpcSub.ID, &rejectNotification{Tx: d.Tx, Reason: d.Reason.Error()})
+				reason := ""
+				if d.Reason != nil {
+					reason = d.Reason.Error()
+				}
+				notifier.Notify(rpcSub.ID, &rejectNotification{Tx: d.Tx, Reason: reason})
 			case <-rpcSub.Err():
 				rejectedSub.Unsubscribe()
 				return