forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-25 14:16:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

triedb/pathdb: define removeFromList function

Browse source
This commit is contained in:
Gary Rong 2025-05-27 21:24:39 +08:00
parent 79617eea5b
commit 285f7898d0
1 changed files with 26 additions and 48 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

74
triedb/pathdb/lookup.go
View file

@ -206,6 +206,30 @@ func (l *lookup) addLayer(diff *diffLayer) {
wg.Wait() wg.Wait()
} }
// removeFromList removes the specified element from the provided list.
// It returns a flag indicating whether the element was found and removed.
func removeFromList(list []common.Hash, element common.Hash) (bool, []common.Hash) {
// Traverse the list from oldest to newest to quickly locate the element.
for i := 0; i < len(list); i++ {
if list[i] == element {
if i != 0 {
list = append(list[:i], list[i+1:]...)
} else {
// Remove the first element by shifting the slice forward.
// Pros: zero-copy.
// Cons: may retain large backing array, causing memory leaks.
// Mitigation: release the array if capacity exceeds threshold.
list = list[1:]
if cap(list) > 1024 {
list = append(make([]common.Hash, 0, len(list)), list...)
}
}
return true, list
}
}
return false, nil
}
// removeLayer traverses the state data retained in the specified diff layer and // removeLayer traverses the state data retained in the specified diff layer and
// unlink them from the lookup set. // unlink them from the lookup set.
func (l *lookup) removeLayer(diff *diffLayer) error { func (l *lookup) removeLayer(diff *diffLayer) error {
@ -219,30 +243,7 @@ func (l *lookup) removeLayer(diff *diffLayer) error {
) )
wg.Go(func() error { wg.Go(func() error {
for accountHash := range diff.states.accountData { for accountHash := range diff.states.accountData {
var ( found, list := removeFromList(l.accounts[accountHash], state)
found bool
list = l.accounts[accountHash]
)
// Traverse the list from oldest to newest to quickly locate the ID
// of the stale layer.
for i := 0; i < len(list); i++ {
if list[i] == state {
if i == 0 {
// Remove the first element by shifting the slice forward.
// Pros: zero-copy.
// Cons: may retain large backing array, causing memory leaks.
// Mitigation: release the array if capacity exceeds threshold.
list = list[1:]
if cap(list) > 1024 {
list = append(make([]common.Hash, 0, len(list)), list...)
}
} else {
list = append(list[:i], list[i+1:]...)
}
found = true
break
}
}
if !found { if !found {
return fmt.Errorf("account lookup is not found, %x, state: %x", accountHash, state) return fmt.Errorf("account lookup is not found, %x, state: %x", accountHash, state)
} }
@ -262,30 +263,7 @@ func (l *lookup) removeLayer(diff *diffLayer) error {
return fmt.Errorf("storage lookup is not found, %x", accountHash) return fmt.Errorf("storage lookup is not found, %x", accountHash)
} }
for slotHash := range slots { for slotHash := range slots {
var ( found, list := removeFromList(subset[slotHash], state)
found bool
list = subset[slotHash]
)
// Traverse the list from oldest to newest to quickly locate the ID
// of the stale layer.
for i := 0; i < len(list); i++ {
if list[i] == state {
if i == 0 {
// Remove the first element by shifting the slice forward.
// Pros: zero-copy.
// Cons: may retain large backing array, causing memory leaks.
// Mitigation: release the array if capacity exceeds threshold.
list = list[1:]
if cap(list) > 1024 {
list = append(make([]common.Hash, 0, len(list)), list...)
}
} else {
list = append(list[:i], list[i+1:]...)
}
found = true
break
}
}
if !found { if !found {
return fmt.Errorf("storage lookup is not found, %x %x, state: %x", accountHash, slotHash, state) return fmt.Errorf("storage lookup is not found, %x %x, state: %x", accountHash, slotHash, state)
} }