From 2a710148103caed151d3c386c13eade5c4695b3a Mon Sep 17 00:00:00 2001 From: Gary Rong Date: Thu, 8 May 2025 16:02:44 +0800 Subject: [PATCH] cmd/workload: address comments from matt --- cmd/workload/tracetest.go | 5 ++--- cmd/workload/tracetestgen.go | 14 ++++++-------- 2 files changed, 8 insertions(+), 11 deletions(-) diff --git a/cmd/workload/tracetest.go b/cmd/workload/tracetest.go index 6e067008ac..2cb818dfb7 100644 --- a/cmd/workload/tracetest.go +++ b/cmd/workload/tracetest.go @@ -39,9 +39,8 @@ type traceTest struct { } type traceTestSuite struct { - cfg testConfig - tests traceTest - + cfg testConfig + tests traceTest invalidDir string } diff --git a/cmd/workload/tracetestgen.go b/cmd/workload/tracetestgen.go index 02309ab164..db36b5bb20 100644 --- a/cmd/workload/tracetestgen.go +++ b/cmd/workload/tracetestgen.go @@ -117,23 +117,21 @@ func generateTraceTests(clictx *cli.Context) error { result, err := client.Geth.TraceTransaction(ctx, tx.Hash(), config) if err != nil { failed += 1 - continue + break } blob, err := json.Marshal(result) if err != nil { failed += 1 - continue + break } test.TxHashes = append(test.TxHashes, tx.Hash()) test.TraceConfigs = append(test.TraceConfigs, *config) test.ResultHashes = append(test.ResultHashes, crypto.Keccak256Hash(blob)) - writeTraceResult(outputDir, tx.Hash(), result, configName) - - if time.Since(logged) > time.Second*8 { - logged = time.Now() - log.Info("Tracing transactions", "executed", len(test.TxHashes), "failed", failed, "elapsed", common.PrettyDuration(time.Since(start))) - } + } + if time.Since(logged) > time.Second*8 { + logged = time.Now() + log.Info("Tracing transactions", "executed", len(test.TxHashes), "failed", failed, "elapsed", common.PrettyDuration(time.Since(start))) } } log.Info("Traced transactions", "executed", len(test.TxHashes), "failed", failed, "elapsed", common.PrettyDuration(time.Since(start)))