forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-17 18:30:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

rpc: use atomic types #27214 (#988)

Browse source 
rpc: use atomic type

Co-authored-by: s7v7nislands <s7v7nislands@gmail.com>
This commit is contained in:
Daniel Liu 2025-04-28 09:19:07 +08:00 committed by GitHub
parent e9b0bc7d74
commit 2ad5333196
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
rpc/client.go
View file

@ -78,7 +78,7 @@ type Client struct {
isHTTP bool isHTTP bool
services *serviceRegistry services *serviceRegistry
idCounter uint32 idCounter atomic.Uint32
// This function, if non-nil, is called when the connection is lost. // This function, if non-nil, is called when the connection is lost.
reconnectFunc reconnectFunc reconnectFunc reconnectFunc
@ -235,7 +235,7 @@ func (c *Client) RegisterName(name string, receiver interface{}) error {
} }
func (c *Client) nextID() json.RawMessage { func (c *Client) nextID() json.RawMessage {
id := atomic.AddUint32(&c.idCounter, 1) id := c.idCounter.Add(1)
return strconv.AppendUint(nil, uint64(id), 10) return strconv.AppendUint(nil, uint64(id), 10)
} }

10
rpc/server.go
View file

@ -48,7 +48,7 @@ type Server struct {
mutex sync.Mutex mutex sync.Mutex
codecs map[ServerCodec]struct{} codecs map[ServerCodec]struct{}
run int32 run atomic.Bool
} }
// NewServer creates a new server instance with no registered handlers. // NewServer creates a new server instance with no registered handlers.
@ -56,8 +56,8 @@ func NewServer() *Server {
server := &Server{ server := &Server{
idgen: randomIDGenerator(), idgen: randomIDGenerator(),
codecs: make(map[ServerCodec]struct{}), codecs: make(map[ServerCodec]struct{}),
run: 1,
} }
server.run.Store(true)
// Register the default service providing meta information about the RPC service such // Register the default service providing meta information about the RPC service such
// as the services and methods it offers. // as the services and methods it offers.
rpcService := &RPCService{server} rpcService := &RPCService{server}
@ -95,7 +95,7 @@ func (s *Server) trackCodec(codec ServerCodec) bool {
s.mutex.Lock() s.mutex.Lock()
defer s.mutex.Unlock() defer s.mutex.Unlock()
if atomic.LoadInt32(&s.run) == 0 { if !s.run.Load() {
return false // Don't serve if server is stopped. return false // Don't serve if server is stopped.
} }
s.codecs[codec] = struct{}{} s.codecs[codec] = struct{}{}
@ -114,7 +114,7 @@ func (s *Server) untrackCodec(codec ServerCodec) {
// this mode. // this mode.
func (s *Server) serveSingleRequest(ctx context.Context, codec ServerCodec) { func (s *Server) serveSingleRequest(ctx context.Context, codec ServerCodec) {
// Don't serve if server is stopped. // Don't serve if server is stopped.
if atomic.LoadInt32(&s.run) == 0 { if !s.run.Load() {
return return
} }
@ -144,7 +144,7 @@ func (s *Server) Stop() {
s.mutex.Lock() s.mutex.Lock()
defer s.mutex.Unlock() defer s.mutex.Unlock()
if atomic.CompareAndSwapInt32(&s.run, 1, 0) { if s.run.CompareAndSwap(true, false) {
log.Debug("RPC server shutting down") log.Debug("RPC server shutting down")
for codec := range s.codecs { for codec := range s.codecs {
codec.close() codec.close()