forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-24 21:56:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

swarm/network: must replace node if bucket is full otherwise nodes will get stuck on empty rows

Browse source
This commit is contained in:
zelig 2016-06-23 20:22:48 +02:00
parent 1e9b3c1583
commit 2b1c950193
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
swarm/network/kademlia/kademlia.go
View file

@ -340,7 +340,11 @@ func (self *bucket) insert(node Node) (replaced Node, err error) {
if len(self.nodes) >= self.size { // >= allows us to add peers beyond the bucketsize limitation if len(self.nodes) >= self.size { // >= allows us to add peers beyond the bucketsize limitation
// dev p2p kicks out nodes idle for > 30 s, so here we never replace nodes if // dev p2p kicks out nodes idle for > 30 s, so here we never replace nodes if
// bucket is full // bucket is full
return nil, fmt.Errorf("bucket full") // update, it seems we need to replace nodes
// return nil, fmt.Errorf("bucket full")
replaced := self.nodes[0]
self.nodes = append(self.nodes[1:], node)
return replaced, nil
} }
self.nodes = append(self.nodes, node) self.nodes = append(self.nodes, node)
return return