forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-06-19 21:31:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

log: avoid setting default slog logger in init (#28747)

Browse source 
slog.SetDefault has undesirable side effects. It also sets the default logger destination,
for example. So we should not call it by default in init.
This commit is contained in:
Daniel Liu 2024-11-15 10:02:42 +08:00
parent 14acdf2dd1
commit 31ceca5ef1
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
log/root.go
View file

@ -11,8 +11,7 @@ import (
var root atomic.Value
func init() {
defaultLogger := &logger{slog.New(DiscardHandler())}
SetDefault(defaultLogger)
root.Store(&logger{slog.New(DiscardHandler())})
}
// SetDefault sets the default global logger