From 32199c72183ed40c2ec1105c645c66d62520fe6f Mon Sep 17 00:00:00 2001 From: devopsbo3 <69951731+devopsbo3@users.noreply.github.com> Date: Fri, 10 Nov 2023 12:27:53 -0600 Subject: [PATCH] Revert "rpc, internal/cmdtest: increase timeout in tests (#27083)" This reverts commit cebac05d4c6a66622667ed7a5808eaeb9857040f. --- cmd/geth/consolecmd_test.go | 2 +- internal/cmdtest/test_cmd.go | 2 +- rpc/client.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cmd/geth/consolecmd_test.go b/cmd/geth/consolecmd_test.go index 5046906c0a..46bdf3c90d 100644 --- a/cmd/geth/consolecmd_test.go +++ b/cmd/geth/consolecmd_test.go @@ -116,7 +116,7 @@ func TestAttachWelcome(t *testing.T) { waitForEndpoint(t, endpoint, 3*time.Second) testAttachWelcome(t, geth, endpoint, httpAPIs) }) - geth.Kill() + geth.ExpectExit() } func testAttachWelcome(t *testing.T, geth *testgeth, endpoint, apis string) { diff --git a/internal/cmdtest/test_cmd.go b/internal/cmdtest/test_cmd.go index df5107952e..fd7a4a8b7f 100644 --- a/internal/cmdtest/test_cmd.go +++ b/internal/cmdtest/test_cmd.go @@ -237,7 +237,7 @@ func (tt *TestCmd) Kill() { } func (tt *TestCmd) withKillTimeout(fn func()) { - timeout := time.AfterFunc(30*time.Second, func() { + timeout := time.AfterFunc(5*time.Second, func() { tt.Log("killing the child process (timeout)") tt.Kill() }) diff --git a/rpc/client.go b/rpc/client.go index fae8536b26..fbeb5a1814 100644 --- a/rpc/client.go +++ b/rpc/client.go @@ -43,7 +43,7 @@ var ( const ( // Timeouts defaultDialTimeout = 10 * time.Second // used if context has no deadline - subscribeTimeout = 10 * time.Second // overall timeout eth_subscribe, rpc_modules calls + subscribeTimeout = 5 * time.Second // overall timeout eth_subscribe, rpc_modules calls ) const (