forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-20 10:52:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

even more review feedback

Browse source
This commit is contained in:
Guillaume Ballet 2019-07-19 17:20:15 +02:00
parent 871984fa70
commit 3711bef1e3
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
accounts/usbwallet/ledger.go
View file

@ -170,7 +170,7 @@ func (w *ledgerDriver) SignTx(path accounts.DerivationPath, tx *types.Transactio
// SignData sends a blob of data to the USB device and waits for the user to confirm // SignData sends a blob of data to the USB device and waits for the user to confirm
// or deny the signing request. // or deny the signing request.
func (w *ledgerDriver) SignData(path accounts.DerivationPath, hash []byte) (common.Address, []byte, error) { func (w *ledgerDriver) SignData(path accounts.DerivationPath, data []byte) (common.Address, []byte, error) {
return common.Address{}, nil, accounts.ErrNotSupported return common.Address{}, nil, accounts.ErrNotSupported
} }

2
signer/core/signed_data.go
View file

@ -144,7 +144,7 @@ func (api *SignerAPI) sign(addr common.MixedcaseAddress, req *SignDataRequest, l
} }
// Only ask for the passphrase if the account is keystore based // Only ask for the passphrase if the account is keystore based
pw := "" pw := ""
if strings.Compare(wallet.URL().Scheme, "keystore") == 0 { if wallet.URL().Scheme == "keystore" {
pw, err = api.lookupOrQueryPassword(account.Address, pw, err = api.lookupOrQueryPassword(account.Address,
"Password for signing", "Password for signing",
fmt.Sprintf("Please enter password for signing data with account %s", account.Address.Hex())) fmt.Sprintf("Please enter password for signing data with account %s", account.Address.Hex()))