forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-27 15:16:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

clean up the PR a bit

Browse source
This commit is contained in:
Jared Wasinger 2025-03-31 17:56:28 +02:00
parent f20b5a4da0
commit 3793060bee
1 changed files with 19 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
eth/downloader/resultstore.go
View file

@ -35,10 +35,9 @@ type resultStore struct {
// *important* : is not safe to use for indexing without checking against length // *important* : is not safe to use for indexing without checking against length
indexIncomplete atomic.Int32 indexIncomplete atomic.Int32
// keep track of the total non-blob gas used in the headers we are scheduling. when we // keep track of the total non-blob gas used in the headers we are scheduling for retrieval.
// exceed a threshold, we will throttle preventing additional requests until some current // when we exceed a threshold, we will throttle preventing additional requests until
// ones have completed. // some current ones have completed.
// TODO: may want to incorporate blob gas into this
itemsGasUsed uint64 itemsGasUsed uint64
lock sync.RWMutex lock sync.RWMutex
@ -92,18 +91,26 @@ func (r *resultStore) GetDeliverySlot(headerNumber uint64) (*fetchResult, bool,
return res, stale, err return res, stale, err
} }
// throttleThreshold returns whether the given result index is throttled.
// If the cumulative gas used of all scheduled headers before the given index
// exceeds a threshold, then the index is throttled.
// Cumulative gas used for a set of blocks is used as a proxy for the worst-case
// size of the blocks. Worst-case block size is estimated by assuming that the
// blocks each contain a transaction filled with calldata that is all zeroes.
// The size of a worst-case block is ~= gasUsed / 10
func (r *resultStore) throttleThreshold(index int) bool {
// estimate the average block size of all scheduled blocks
estBlockSize := max((r.itemsGasUsed/(uint64(index)+1))/10, 524)
throttleThreshold := min(uint64(len(r.items)), uint64(blockCacheMemory)/estBlockSize+1)
return index >= int(throttleThreshold)
}
// getFetchResult returns the fetchResult corresponding to the given item, and // getFetchResult returns the fetchResult corresponding to the given item, and
// the index where the result is stored. // the index where the result is stored.
func (r *resultStore) getFetchResult(headerNumber uint64) (item *fetchResult, index int, stale, throttle bool, err error) { func (r *resultStore) getFetchResult(headerNumber uint64) (item *fetchResult, index int, stale, throttle bool, err error) {
index = int(int64(headerNumber) - int64(r.resultOffset)) index = int(int64(headerNumber) - int64(r.resultOffset))
throttle = r.throttleThreshold(index)
// estimate an average block size based on the worst case:
// a block filled with calldata containing all zeroes
// costing ~10 gas per byte of calldata.
avgEstimatedBlockSize := max((r.itemsGasUsed/(uint64(index)+1))/10, 524)
throttleThreshold := min(uint64(len(r.items)), uint64(blockCacheMemory)/avgEstimatedBlockSize)
throttle = index >= int(throttleThreshold)
stale = index < 0 stale = index < 0
if index >= len(r.items) { if index >= len(r.items) {