forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-06-04 14:08:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

p2p/nat: server list contains IPv6 servers (#35084)

Browse source 
stun-list.txt includes 10 bracketd IPv6 server, but the dial network is
fixed to "udp4"
This commit is contained in:
cui 2026-06-02 23:13:36 +08:00 committed by GitHub
parent 19f5fe079b
commit 38667bc64e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
p2p/nat/nat_test.go
View file

@ -73,6 +73,7 @@ func TestParseStun(t *testing.T) {
}{ }{
{"stun", &stun{serverList: strings.Split(stunDefaultServers, "\n")}}, {"stun", &stun{serverList: strings.Split(stunDefaultServers, "\n")}},
{"stun:1.2.3.4:1234", &stun{serverList: []string{"1.2.3.4:1234"}}}, {"stun:1.2.3.4:1234", &stun{serverList: []string{"1.2.3.4:1234"}}},
{"stun:[2001:db8::1]:3478", &stun{serverList: []string{"[2001:db8::1]:3478"}}},
} }
for _, tc := range testcases { for _, tc := range testcases {

4
p2p/nat/stun.go
View file

@ -45,7 +45,7 @@ func newSTUN(serverAddr string) (Interface, error) {
if serverAddr == "" { if serverAddr == "" {
s.serverList = strings.Split(stunDefaultServers, "\n") s.serverList = strings.Split(stunDefaultServers, "\n")
} else { } else {
_, err := net.ResolveUDPAddr("udp4", serverAddr) _, err := net.ResolveUDPAddr("udp", serverAddr)
if err != nil { if err != nil {
return nil, err return nil, err
} }
@ -111,7 +111,7 @@ func (s *stun) externalIP(server string) (net.IP, error) {
} }
log.Trace("Attempting STUN binding request", "server", server) log.Trace("Attempting STUN binding request", "server", server)
conn, err := stunV3.Dial("udp4", server) conn, err := stunV3.Dial("udp", server)
if err != nil { if err != nil {
return nil, err return nil, err
} }