forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-17 17:33:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

eth/gasprice: Sort transactions by price first, to minimise use of ecrecover

Browse source
This commit is contained in:
Nick Johnson 2018-01-09 11:27:21 +00:00
parent 67d1681137
commit 38e8ac09c9
1 changed files with 14 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
eth/gasprice/gasprice.go
View file

@ -152,7 +152,13 @@ type getBlockPricesResult struct {
err error err error
} }
// getLowestPrice calculates the lowest transaction gas price in a given block type transactionsByGasPrice []*types.Transaction
func (t transactionsByGasPrice) Len() int { return len(t) }
func (t transactionsByGasPrice) Swap(i, j int) { t[i], t[j] = t[j], t[i] }
func (t transactionsByGasPrice) Less(i, j int) bool { return t[i].GasPrice().Cmp(t[j].GasPrice()) < 0 }
// getBlockPrices calculates the lowest transaction gas price in a given block
// and sends it to the result channel. If the block is empty, price is nil. // and sends it to the result channel. If the block is empty, price is nil.
func (gpo *Oracle) getBlockPrices(ctx context.Context, signer types.Signer, blockNum uint64, ch chan getBlockPricesResult) { func (gpo *Oracle) getBlockPrices(ctx context.Context, signer types.Signer, blockNum uint64, ch chan getBlockPricesResult) {
block, err := gpo.backend.BlockByNumber(ctx, rpc.BlockNumber(blockNum)) block, err := gpo.backend.BlockByNumber(ctx, rpc.BlockNumber(blockNum))
@ -160,18 +166,18 @@ func (gpo *Oracle) getBlockPrices(ctx context.Context, signer types.Signer, bloc
ch <- getBlockPricesResult{nil, err} ch <- getBlockPricesResult{nil, err}
return return
} }
txs := block.Transactions() txs := block.Transactions()
var minPrice *big.Int sort.Sort(transactionsByGasPrice(txs))
for _, tx := range txs { for _, tx := range txs {
sender, err := types.Sender(signer, tx) sender, err := types.Sender(signer, tx)
if err != nil || sender == block.Coinbase() { if err == nil && sender != block.Coinbase() {
continue ch <- getBlockPricesResult{tx.GasPrice(), nil}
} return
if minPrice == nil || tx.GasPrice().Cmp(minPrice) < 0 {
minPrice = tx.GasPrice()
} }
} }
ch <- getBlockPricesResult{minPrice, nil} ch <- getBlockPricesResult{nil, nil}
} }
type bigIntArray []*big.Int type bigIntArray []*big.Int