From 3a6067c9e4a25831977d5aa1ce150175659dc2b7 Mon Sep 17 00:00:00 2001 From: jsvisa Date: Sat, 1 Mar 2025 03:35:31 +0000 Subject: [PATCH] core/rawdb: replace preimage hits metric with miss Signed-off-by: jsvisa --- core/rawdb/accessors_state.go | 2 +- core/rawdb/schema.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/core/rawdb/accessors_state.go b/core/rawdb/accessors_state.go index 9ce58e7d27..bc726d911b 100644 --- a/core/rawdb/accessors_state.go +++ b/core/rawdb/accessors_state.go @@ -27,6 +27,7 @@ import ( // ReadPreimage retrieves a single preimage of the provided hash. func ReadPreimage(db ethdb.KeyValueReader, hash common.Hash) []byte { data, _ := db.Get(preimageKey(hash)) + preimageMissCounter.Inc(1) return data } @@ -38,7 +39,6 @@ func WritePreimages(db ethdb.KeyValueWriter, preimages map[common.Hash][]byte) { } } preimageCounter.Inc(int64(len(preimages))) - preimageHitCounter.Inc(int64(len(preimages))) } // ReadCode retrieves the contract code of the provided code hash. diff --git a/core/rawdb/schema.go b/core/rawdb/schema.go index 3d5d757a86..48451447ab 100644 --- a/core/rawdb/schema.go +++ b/core/rawdb/schema.go @@ -145,8 +145,8 @@ var ( FixedCommitteeRootKey = []byte("fixedRoot-") // bigEndian64(syncPeriod) -> committee root hash SyncCommitteeKey = []byte("committee-") // bigEndian64(syncPeriod) -> serialized committee - preimageCounter = metrics.NewRegisteredCounter("db/preimage/total", nil) - preimageHitCounter = metrics.NewRegisteredCounter("db/preimage/hits", nil) + preimageCounter = metrics.NewRegisteredCounter("db/preimage/total", nil) + preimageMissCounter = metrics.NewRegisteredCounter("db/preimage/miss", nil) ) // LegacyTxLookupEntry is the legacy TxLookupEntry definition with some unnecessary