From 56d9a6e39c008c1573e218600723fcfe855f3848 Mon Sep 17 00:00:00 2001 From: Daniel Liu Date: Sat, 20 Apr 2024 09:10:57 +0800 Subject: [PATCH] core, filters: not set log.BlockHash --- core/database_util.go | 4 ---- eth/filters/api.go | 5 ----- 2 files changed, 9 deletions(-) diff --git a/core/database_util.go b/core/database_util.go index 81a82305fe..647d6afd3b 100644 --- a/core/database_util.go +++ b/core/database_util.go @@ -262,10 +262,6 @@ func GetBlockReceipts(db DatabaseReader, hash common.Hash, number uint64) types. receipts[i].BlockHash = hash receipts[i].BlockNumber = big.NewInt(0).SetUint64(number) receipts[i].TransactionIndex = uint(i) - for _, log := range receipts[i].Logs { - // update BlockHash to fix #208 - log.BlockHash = hash - } } return receipts } diff --git a/eth/filters/api.go b/eth/filters/api.go index 72d256f30a..952598046d 100644 --- a/eth/filters/api.go +++ b/eth/filters/api.go @@ -28,7 +28,6 @@ import ( ethereum "github.com/XinFinOrg/XDPoSChain" "github.com/XinFinOrg/XDPoSChain/common" "github.com/XinFinOrg/XDPoSChain/common/hexutil" - "github.com/XinFinOrg/XDPoSChain/core" "github.com/XinFinOrg/XDPoSChain/core/types" "github.com/XinFinOrg/XDPoSChain/ethdb" "github.com/XinFinOrg/XDPoSChain/event" @@ -443,10 +442,6 @@ func (api *PublicFilterAPI) GetFilterChanges(id rpc.ID) (interface{}, error) { case LogsSubscription: logs := f.logs f.logs = nil - for _, log := range logs { - // update BlockHash to fix #208 - log.BlockHash = core.GetCanonicalHash(api.chainDb, log.BlockNumber) - } return returnLogs(logs), nil } }