forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-19 02:12:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

GetAccountRange response limit and size checks

Browse source
This commit is contained in:
David Theodore 2024-09-25 09:51:59 -05:00
parent 80b529ea71
commit 3d10a99e7f
1 changed files with 11 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
eth/protocols/snap/handler.go
View file

@ -294,22 +294,25 @@ func ServiceGetAccountRangeQuery(chain *core.BlockChain, req *GetAccountRangePac
for it.Next() { for it.Next() {
hash, account := it.Hash(), common.CopyBytes(it.Account()) hash, account := it.Hash(), common.CopyBytes(it.Account())
// Verify response size does not exceed the requested limit
size += uint64(common.HashLength + len(account))
if size > req.Bytes {
break
}
// If we've exceeded the request threshold, abort
if bytes.Compare(hash[:], req.Limit[:]) > 0 {
break
}
// Track the returned interval for the Merkle proofs // Track the returned interval for the Merkle proofs
last = hash last = hash
// Assemble the reply item // Assemble the reply item
size += uint64(common.HashLength + len(account))
accounts = append(accounts, &AccountData{ accounts = append(accounts, &AccountData{
Hash: hash, Hash: hash,
Body: account, Body: account,
}) })
// If we've exceeded the request threshold, abort
if bytes.Compare(hash[:], req.Limit[:]) >= 0 {
break
}
if size > req.Bytes {
break
}
} }
it.Release() it.Release()