diff --git a/cmd/devp2p/internal/ethtest/suite.go b/cmd/devp2p/internal/ethtest/suite.go index 52baa41969..b486eb26d9 100644 --- a/cmd/devp2p/internal/ethtest/suite.go +++ b/cmd/devp2p/internal/ethtest/suite.go @@ -89,7 +89,6 @@ func (s *Suite) EthTests() []utesting.Test { {Name: "InvalidTxs", Fn: s.TestInvalidTxs}, {Name: "NewPooledTxs", Fn: s.TestNewPooledTxs}, {Name: "BlobViolations", Fn: s.TestBlobViolations}, - //todo: 4 tests below requires hive test changes {Name: "TestBlobTxWithoutSidecar", Fn: s.TestBlobTxWithoutSidecar}, {Name: "TestBlobTxWithMismatchedSidecar", Fn: s.TestBlobTxWithMismatchedSidecar}, // test eth/72 blob txs diff --git a/core/txpool/blobpool/blobpool.go b/core/txpool/blobpool/blobpool.go index a2230c9d49..f684d58f30 100644 --- a/core/txpool/blobpool/blobpool.go +++ b/core/txpool/blobpool/blobpool.go @@ -1691,10 +1691,6 @@ func (p *BlobPool) Get(hash common.Hash) *types.Transaction { } // GetRLP returns an RLP-encoded transaction if it is contained in the pool. -// TODO: The pool internally stores pooledBlobTx (cell sidecar format), but callers expect -// types.Transaction RLP. This requires an additional decode-encode step, which is inefficient -// and contradicts the original purpose of this function. -// Possible improvements: Drop eth70 and store the cell and transaction separately. func (p *BlobPool) GetRLP(hash common.Hash, version uint) []byte { data := p.getRLP(hash) if len(data) == 0 {