tests: s/skipLoad/fails and some more docs

This commit is contained in:
Martin Holst Swende 2018-09-03 19:13:36 +02:00
parent 7ae323ff2a
commit 3eb55f5176
No known key found for this signature in database
GPG key ID: 683B438C05A5DDF0
2 changed files with 3 additions and 1 deletions

View file

@ -31,7 +31,7 @@ func TestBlockchain(t *testing.T) {
bt.skipLoad(`^bcMultiChainTest/(ChainAtoChainB_blockorder|CallContractFromNotBestBlock)`)
bt.skipLoad(`^bcTotalDifficultyTest/(lotsOfLeafs|lotsOfBranches|sideChainWithMoreTransactions)`)
// This test is broken
bt.skipLoad(`blockhashNonConstArg_Constantinople`)
bt.fails(`blockhashNonConstArg_Constantinople`, "Broken test")
// Still failing tests
// bt.skipLoad(`^bcWalletTest.*_Byzantium$`)

View file

@ -156,6 +156,8 @@ func (t *StateTest) Run(subtest StateSubtest, vmconfig vm.Config) (*state.StateD
statedb.AddBalance(block.Coinbase(), new(big.Int))
// And _now_ get the state root
root := statedb.IntermediateRoot(config.IsEIP158(block.Number()))
// N.B: We need to do this in a two-step process, because the first Commit takes care
// of suicides, and we need to touch the coinbase _after_ it has potentially suicided.
if root != common.Hash(post.Root) {
return statedb, fmt.Errorf("post state root mismatch: got %x, want %x", root, post.Root)
}