forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-21 12:16:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

types,ethapi,signer: avoid copying 128KB blobs in range loops

Browse source
This commit is contained in:
Lessa 2026-01-29 16:20:46 -05:00
parent 845009f684
commit 41467e8287
3 changed files with 13 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
core/types/tx_blob.go
View file

@ -118,8 +118,8 @@ func (sc *BlobTxSidecar) ToV1() error {
} }
if sc.Version == BlobSidecarVersion0 { if sc.Version == BlobSidecarVersion0 {
proofs := make([]kzg4844.Proof, 0, len(sc.Blobs)*kzg4844.CellProofsPerBlob) proofs := make([]kzg4844.Proof, 0, len(sc.Blobs)*kzg4844.CellProofsPerBlob)
for _, blob := range sc.Blobs { for i := range sc.Blobs {
cellProofs, err := kzg4844.ComputeCellProofs(&blob) cellProofs, err := kzg4844.ComputeCellProofs(&sc.Blobs[i])
if err != nil { if err != nil {
return err return err
} }

12
internal/ethapi/transaction_args.go
View file

@ -329,8 +329,8 @@ func (args *TransactionArgs) setBlobTxSidecar(ctx context.Context, config sideca
commitments = make([]kzg4844.Commitment, n) commitments = make([]kzg4844.Commitment, n)
proofs = make([]kzg4844.Proof, 0, proofLen) proofs = make([]kzg4844.Proof, 0, proofLen)
) )
for i, b := range args.Blobs { for i := range args.Blobs {
c, err := kzg4844.BlobToCommitment(&b) c, err := kzg4844.BlobToCommitment(&args.Blobs[i])
if err != nil { if err != nil {
return fmt.Errorf("blobs[%d]: error computing commitment: %v", i, err) return fmt.Errorf("blobs[%d]: error computing commitment: %v", i, err)
} }
@ -338,13 +338,13 @@ func (args *TransactionArgs) setBlobTxSidecar(ctx context.Context, config sideca
switch config.blobSidecarVersion { switch config.blobSidecarVersion {
case types.BlobSidecarVersion0: case types.BlobSidecarVersion0:
p, err := kzg4844.ComputeBlobProof(&b, c) p, err := kzg4844.ComputeBlobProof(&args.Blobs[i], c)
if err != nil { if err != nil {
return fmt.Errorf("blobs[%d]: error computing proof: %v", i, err) return fmt.Errorf("blobs[%d]: error computing proof: %v", i, err)
} }
proofs = append(proofs, p) proofs = append(proofs, p)
case types.BlobSidecarVersion1: case types.BlobSidecarVersion1:
ps, err := kzg4844.ComputeCellProofs(&b) ps, err := kzg4844.ComputeCellProofs(&args.Blobs[i])
if err != nil { if err != nil {
return fmt.Errorf("blobs[%d]: error computing proof: %v", i, err) return fmt.Errorf("blobs[%d]: error computing proof: %v", i, err)
} }
@ -356,8 +356,8 @@ func (args *TransactionArgs) setBlobTxSidecar(ctx context.Context, config sideca
} else { } else {
switch config.blobSidecarVersion { switch config.blobSidecarVersion {
case types.BlobSidecarVersion0: case types.BlobSidecarVersion0:
for i, b := range args.Blobs { for i := range args.Blobs {
if err := kzg4844.VerifyBlobProof(&b, args.Commitments[i], args.Proofs[i]); err != nil { if err := kzg4844.VerifyBlobProof(&args.Blobs[i], args.Commitments[i], args.Proofs[i]); err != nil {
return fmt.Errorf("failed to verify blob proof: %v", err) return fmt.Errorf("failed to verify blob proof: %v", err)
} }
} }

10
signer/core/apitypes/types.go
View file

@ -246,13 +246,13 @@ func (args *SendTxArgs) validateTxSidecar() error {
// Generate commitment and proof. // Generate commitment and proof.
commitments := make([]kzg4844.Commitment, n) commitments := make([]kzg4844.Commitment, n)
proofs := make([]kzg4844.Proof, n) proofs := make([]kzg4844.Proof, n)
for i, b := range args.Blobs { for i := range args.Blobs {
c, err := kzg4844.BlobToCommitment(&b) c, err := kzg4844.BlobToCommitment(&args.Blobs[i])
if err != nil { if err != nil {
return fmt.Errorf("blobs[%d]: error computing commitment: %v", i, err) return fmt.Errorf("blobs[%d]: error computing commitment: %v", i, err)
} }
commitments[i] = c commitments[i] = c
p, err := kzg4844.ComputeBlobProof(&b, c) p, err := kzg4844.ComputeBlobProof(&args.Blobs[i], c)
if err != nil { if err != nil {
return fmt.Errorf("blobs[%d]: error computing proof: %v", i, err) return fmt.Errorf("blobs[%d]: error computing proof: %v", i, err)
} }
@ -261,8 +261,8 @@ func (args *SendTxArgs) validateTxSidecar() error {
args.Commitments = commitments args.Commitments = commitments
args.Proofs = proofs args.Proofs = proofs
} else { } else {
for i, b := range args.Blobs { for i := range args.Blobs {
if err := kzg4844.VerifyBlobProof(&b, args.Commitments[i], args.Proofs[i]); err != nil { if err := kzg4844.VerifyBlobProof(&args.Blobs[i], args.Commitments[i], args.Proofs[i]); err != nil {
return fmt.Errorf("failed to verify blob proof: %v", err) return fmt.Errorf("failed to verify blob proof: %v", err)
} }
} }