From 4209f1c5c0b14d2e710f7dfdb9eaeb65c9443c1c Mon Sep 17 00:00:00 2001 From: Quentin Mc Gaw Date: Mon, 20 Jan 2025 09:52:09 +0100 Subject: [PATCH] Self-review errors.As pointer usage --- p2p/dnsdisc/error.go | 2 +- rlp/typecache.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/p2p/dnsdisc/error.go b/p2p/dnsdisc/error.go index ef28a6710f..4c129b28f7 100644 --- a/p2p/dnsdisc/error.go +++ b/p2p/dnsdisc/error.go @@ -47,7 +47,7 @@ type nameError struct { } func (err nameError) Error() string { - ee := new(entryError) + var ee entryError if errors.As(err.err, &ee) { return fmt.Sprintf("invalid %s entry at %s: %v", ee.typ, err.name, ee.err) } diff --git a/rlp/typecache.go b/rlp/typecache.go index ed32480629..ba85eff882 100644 --- a/rlp/typecache.go +++ b/rlp/typecache.go @@ -141,7 +141,7 @@ func structFields(typ reflect.Type) (fields []field, err error) { // Filter/validate fields. structFields, structTags, err := rlpstruct.ProcessFields(allStructFields) if err != nil { - tagErr := new(rlpstruct.TagError) + var tagErr rlpstruct.TagError if errors.As(err, &tagErr) { tagErr.StructType = typ.String() return nil, tagErr