forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-19 11:20:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

eth/protocols/eth: discard message before size check

Browse source 
Move msg.Discard defer ahead of the max message size check so oversized
messages are released instead of leaking when the handler returns early.
This commit is contained in:
Weixie Cui 2026-07-03 20:00:00 +08:00
parent 7aa7806c09
commit 421d4810d5
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
eth/protocols/eth/handler.go
View file

@ -224,10 +224,10 @@ func handleMessage(backend Backend, peer *Peer) error {
if err != nil { if err != nil {
return err return err
} }
defer msg.Discard()
if msg.Size > maxMessageSize { if msg.Size > maxMessageSize {
return fmt.Errorf("%w: %v > %v", errMsgTooLarge, msg.Size, maxMessageSize) return fmt.Errorf("%w: %v > %v", errMsgTooLarge, msg.Size, maxMessageSize)
} }
defer msg.Discard()
var handlers map[uint64]msgHandler var handlers map[uint64]msgHandler
switch peer.version { switch peer.version {

2
eth/protocols/snap/handler.go
View file

@ -160,10 +160,10 @@ func HandleMessage(backend Backend, peer *Peer) error {
if err != nil { if err != nil {
return err return err
} }
defer msg.Discard()
if msg.Size > maxMessageSize { if msg.Size > maxMessageSize {
return fmt.Errorf("%w: %v > %v", errMsgTooLarge, msg.Size, maxMessageSize) return fmt.Errorf("%w: %v > %v", errMsgTooLarge, msg.Size, maxMessageSize)
} }
defer msg.Discard()
var handlers map[uint64]msgHandler var handlers map[uint64]msgHandler
switch peer.version { switch peer.version {