forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-20 10:52:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

rpc: fix leak in TestClientHTTP by making errc buffered

Browse source 
This avoids adding an extra stop channel.
This commit is contained in:
Felix Lange 2020-04-03 13:54:20 +02:00
parent 5da0694ede
commit 42cd72aba4
1 changed files with 2 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
rpc/client_test.go
View file

@ -413,21 +413,14 @@ func TestClientHTTP(t *testing.T) {
// Launch concurrent requests.
var (
results = make([]echoResult, 100)
errc = make(chan error)
errc = make(chan error, len(results))
wantResult = echoResult{"a", 1, new(echoArgs)}
stop = make(chan struct{})
)
defer close(stop)
defer client.Close()
for i := range results {
i := i
go func() {
select {
case <-stop:
return
case errc <- client.Call(&results[i], "test_echo",
wantResult.String, wantResult.Int, wantResult.Args):
}
errc <- client.Call(&results[i], "test_echo", wantResult.String, wantResult.Int, wantResult.Args)
}()
}