From 4320189830090d07bd8dfb4258ce769a24e1524f Mon Sep 17 00:00:00 2001 From: Chris Ziogas Date: Fri, 29 Mar 2024 13:01:41 +0200 Subject: [PATCH] try a fix for test to pass on Windows We try to solve the following error: ``` --- FAIL: TestSupplySelfdestruct (1.56s) testing.go:1231: TempDir RemoveAll cleanup: remove C:\Users\appveyor\AppData\Local\Temp\1\TestSupplySelfdestruct3803137642\001\supply.jsonl: The process cannot access the file because it is being used by another process. ``` --- eth/tracers/internal/tracetest/supply_test.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/eth/tracers/internal/tracetest/supply_test.go b/eth/tracers/internal/tracetest/supply_test.go index e933576f7b..9f4f9f692f 100644 --- a/eth/tracers/internal/tracetest/supply_test.go +++ b/eth/tracers/internal/tracetest/supply_test.go @@ -530,13 +530,14 @@ func testSupplyTracer(t *testing.T, genesis *core.Genesis, gen func(*core.BlockG traceOutputPath := filepath.ToSlash(t.TempDir()) traceOutputFilename := path.Join(traceOutputPath, "supply.jsonl") - defer os.Remove(traceOutputFilename) // Load supply tracer tracer, err := tracers.LiveDirectory.New("supply", json.RawMessage(fmt.Sprintf(`{"path":"%s"}`, traceOutputPath))) if err != nil { return nil, nil, fmt.Errorf("failed to create call tracer: %v", err) } + // hack so as the supply log file handler closes, for tests to work on windows + defer func() { tracer = nil }() chain, err := core.NewBlockChain(rawdb.NewMemoryDatabase(), core.DefaultCacheConfigWithScheme(rawdb.PathScheme), genesis, nil, engine, vm.Config{Tracer: tracer}, nil, nil) if err != nil {