Log info about mismatched valset (#1325)

This commit is contained in:
Jerry 2024-09-06 10:30:48 -07:00 committed by GitHub
parent 94ead5eb76
commit 44d0938775
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -360,6 +360,7 @@ func (c *Bor) verifyHeader(chain consensus.ChainHeaderReader, header *types.Head
} }
if isSprintEnd && signersBytes%validatorHeaderBytesLength != 0 { if isSprintEnd && signersBytes%validatorHeaderBytesLength != 0 {
log.Warn("Invalid validator set", "number", number, "signersBytes", signersBytes)
return errInvalidSpanValidators return errInvalidSpanValidators
} }
@ -478,11 +479,13 @@ func (c *Bor) verifyCascadingFields(chain consensus.ChainHeaderReader, header *t
} }
if len(newValidators) != len(headerVals) { if len(newValidators) != len(headerVals) {
log.Warn("Invalid validator set", "block number", number, "newValidators", newValidators, "headerVals", headerVals)
return errInvalidSpanValidators return errInvalidSpanValidators
} }
for i, val := range newValidators { for i, val := range newValidators {
if !bytes.Equal(val.HeaderBytes(), headerVals[i].HeaderBytes()) { if !bytes.Equal(val.HeaderBytes(), headerVals[i].HeaderBytes()) {
log.Warn("Invalid validator set", "block number", number, "index", i, "local validator", val, "header validator", headerVals[i])
return errInvalidSpanValidators return errInvalidSpanValidators
} }
} }
@ -1416,6 +1419,11 @@ func getUpdatedValidatorSet(oldValidatorSet *valset.ValidatorSet, newVals []*val
} }
if err := v.UpdateWithChangeSet(changes); err != nil { if err := v.UpdateWithChangeSet(changes); err != nil {
changesStr := ""
for _, change := range changes {
changesStr += fmt.Sprintf("Address: %s, VotingPower: %d\n", change.Address, change.VotingPower)
}
log.Warn("Changes in validator set", "changes", changesStr)
log.Error("Error while updating change set", "error", err) log.Error("Error while updating change set", "error", err)
} }