From 44fc298c77e326065b7d436940ebba9bd4f7b221 Mon Sep 17 00:00:00 2001 From: lightclient Date: Mon, 22 Jan 2024 09:43:42 -0700 Subject: [PATCH] eth/catalyst: add note about invalid payload attr error --- eth/catalyst/api.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/eth/catalyst/api.go b/eth/catalyst/api.go index 0f0134165d..362a7f3377 100644 --- a/eth/catalyst/api.go +++ b/eth/catalyst/api.go @@ -202,6 +202,10 @@ func (api *ConsensusAPI) ForkchoiceUpdatedV2(update engine.ForkchoiceStateV1, pa // ForkchoiceUpdatedV3 is equivalent to V2 with the addition of parent beacon block root in the payload attributes. func (api *ConsensusAPI) ForkchoiceUpdatedV3(update engine.ForkchoiceStateV1, params *engine.PayloadAttributes) (engine.ForkChoiceResponse, error) { if params != nil { + // TODO(matt): according to https://github.com/ethereum/execution-apis/pull/498, + // payload attributes that are invalid should return error + // engine.InvalidPayloadAttributes. Once hive updates this, we should update + // on our end. if params.Withdrawals == nil { return engine.STATUS_INVALID, engine.InvalidParams.With(errors.New("missing withdrawals")) }