test(node): more linters #24783 (#1996)

node/config_test.go

@@ -65,10 +65,9 @@ func TestDatadirCreation(t *testing.T) {
 	dir = filepath.Join(file.Name(), "invalid/path")
 	node, err = New(&Config{DataDir: dir})
 	if err == nil {
+		// Ensure resources are cleaned up even on unexpected success.
+		_ = node.Close()
 		t.Fatalf("protocol stack created with an invalid datadir")
-		if err := node.Close(); err != nil {
-			t.Fatalf("failed to close node: %v", err)
-		}
 	}
 }
 

node/utils_test.go

@@ -47,8 +47,6 @@ type InstrumentedService struct {
 
 	startHook func()
 	stopHook  func()
-
-	protocols []p2p.Protocol
 }
 
 func (s *InstrumentedService) Start() error {